Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new repo under jenkins-infra for the Jenkins Contributor Spotlight feature on jenkins.io #3809

Closed
krisstern opened this issue Oct 31, 2023 · 18 comments

Comments

@krisstern
Copy link
Member

krisstern commented Oct 31, 2023

Service(s)

GitHub, jenkins.io

Summary

We would like to host this Gatsby.js app for the Jenkins Contributor Spotlight feature with the URL https://contributors.jenkins.io/ (i.e. with contributors as the jenkins.io subdomain. A separate PR will be opened at https://github.com/jenkins-infra/jenkins-io-components to add this URL to the header formally in a later step.

Repo has been imported under jenkins-infra at https://github.com/jenkins-infra/jenkins-contributor-spotlight.

c.c. @kmartens27 @alyssat

Reproduction steps

N/A

EDIT @lemeurherve: detailled action plan at #3809 (comment)

@krisstern krisstern added the triage Incoming issues that need review label Oct 31, 2023
@MarkEWaite
Copy link

Will this be in addition to the existing content on https://stories.jenkins.io/ ?

The current stories.jenkins.io page content is hosted at https://github.com/jenkins-infra/stories

@kmartens27
Copy link
Collaborator

kmartens27 commented Oct 31, 2023

@MarkEWaite Would it make more sense to have it as an entity on jenkins.io, like how the blog exists and has its own content, or as a separate page/content section for stories.jenkins.io?

@MarkEWaite
Copy link

MarkEWaite commented Oct 31, 2023

I like very much that the site is being generated with Gatsby and that it has its own design. That's aligned with the direction that @krisstern is leading with the versioned documentation project from Google Summer of Code.

I was curious if the current definition of stories.jenkins.io would be extended with the contributor stories or if there should be a new top level domain like https://contributors.jenkins.io

@kmartens27
Copy link
Collaborator

I think there are positives to both options, but having it extend the definition of stories.jenkins.io would get more visitors to that and provide a gateway for users and readers to connect to the other stories.
Having a separate domain could help with the "spotlight" feel/idea that we're going for when highlighting the contributors, but I'm not sure if there's something that could be an issue that I'm unaware of.

@krisstern
Copy link
Member Author

I am wondering where is the code for the existing https://stories.jenkins.io/ hosted? Maybe I could take a look and see how easily I could integrate it to the contributor stories codebase? Or we could keep them separate to retain their different purposes?

Personally I prefer to have the two as separate features, since that way their differences can be kept as they appear to have two very distinct energies. But I am open to exploring different options.

@lemeurherve
Copy link
Member

lemeurherve commented Oct 31, 2023

For the record, here is our last infra meeting notes after discussing with @kmartens47 and @MarkEWaite on the subject:

    * Does it "increment" stories.jenkins.io (`/contributors` for instance)? or does it a secondary website such as contributors.jenkins.io?
        * Already have a 2nd website with previe as per Kris work => secondary website looks easier
        * Proposal: link in stories.jenkins.io to redirect to the new website 
        * contributors.stories.jenkins.io / users.stories.jenkins.io
    * Hypothesis of "secondary website"
        * Need to fork the repo to jenkins-infra
            * WiP: Permission
        * TODO:
            * CI (preview website)
            * Production (same as stories.jenkins.io most probably)
            * CD (extend CI to production)

Going for a distinct website like contributors.jenkins.io seems easier for now, could be revised later.

I'll update this issue with a more detailed infra TODO plan.

@lemeurherve
Copy link
Member

The https://github.com/orgs/jenkins-infra/teams/contributor-spotlight team including @krisstern @kmartens27 and @alyssat has been created and set as maintainer of https://github.com/jenkins-infra/jenkins-contributor-spotlight

@lemeurherve lemeurherve self-assigned this Nov 2, 2023
@lemeurherve lemeurherve removed the triage Incoming issues that need review label Nov 2, 2023
@lemeurherve
Copy link
Member

lemeurherve commented Nov 22, 2023

Action plan

@lemeurherve
Copy link
Member

@jenkins-infra/contributor-spotlight I propose to rename the repository from "jenkins-contributor-spotlight" to "contributor-spotlight", WDYT?

@lemeurherve
Copy link
Member

lemeurherve commented Nov 22, 2023

Also, what's the correct spelling of the project?
"Contributors Spotlight" (plural like "stories") or "Contributor Spotlight"?

@krisstern
Copy link
Member Author

I reckon we could use "Contributors Spotlight" instead, since that may be more apt as we will be spotlighting more than 1 contributor at any one time from the look of things. Sure, we could remove "jenkins" from the current GitHub repo name.

@MarkEWaite
Copy link

MarkEWaite commented Nov 22, 2023

I reckon we could use "Contributors Spotlight" instead, since that may be more apt as we will be spotlighting more than 1 contributor at any one time from the look of things. Sure, we could remove "jenkins" from the current GitHub repo name.

I disagree. I think that a spotlight in this case is intended to shine on one person at a time. Some examples of the use of "Contributor Spotlight" include:

When I initially searched for "Contributors Spotlight", Google search showed me "Contributor Spotlight" entries.

I like the removal of the redundant "jenkins-" prefix from the repository name. That matches with our patterns elsewhere of not placing "jenkins-" in the repository name.

@kmartens27
Copy link
Collaborator

Just to echo what @MarkEWaite said, there will be a singular contributor spotlighted at a time. I also agree with removing the jenkins piece of the repo name as it is a bit redundant/out of line with the other repos.

@lemeurherve
Copy link
Member

I've renamed the repository contributor-spotlight.

@lemeurherve
Copy link
Member

Update: CI part done 🎉

jenkins-infra/contributor-spotlight#15 (comment)

lemeurherve added a commit to jenkins-infra/azure that referenced this issue Nov 23, 2023
This PR creates a resource group and a storage account to store the
static HTML content generated by
jenkins-infra/contributor-spotlight#15 and which
will be mounted as volume to be served on contributors.origin.jenkins.io
from `publick8s` cluster. (contributors.jenkins.io will be served by the
CDN Fastly)
This content doesn't need to be accessible from elsewhere, hence the
network protection.

Ref:
-
jenkins-infra/helpdesk#3809 (comment)
lemeurherve added a commit to jenkins-infra/azure that referenced this issue Nov 23, 2023
This PR adds the File Share that will be used by the nginx-website
release on publick8s cluster to serve on contributors.origin.jenkins.io
the content generated in
https://github.com/jenkins-infra/contributor-spotlight/.

It also rename the storage account resource to be uniform.

Follow-up of #523 

Ref:
-
jenkins-infra/helpdesk#3809 (comment)
lemeurherve added a commit to jenkins-infra/azure that referenced this issue Nov 27, 2023
…re (#528)

This PR recreates the storage account and the file share for
contributors.jenkins.io

The network rules deleted in a hotfix commit were still present when
looking at the storage account in Azure Portal.
I've deleted the (empty) storage account to recreate it with this PR.

Other changes:
- ZRS: no need for GRS, ZRS is sufficient
- Type StorageV2: default value from the terraform provider, "Storage"
(v1) is the legacy one, no cost change between them.
- Add back network rules, allowing our IPs and the ones from publick8s
and privatek8s vnets.

Follow-up of:
- #523
- #524

Ref:
-
jenkins-infra/helpdesk#3809 (comment)
lemeurherve added a commit to jenkins-infra/azure that referenced this issue Nov 28, 2023
This PR adds outputs to retrieve fine grained File Share SAS token so we
can use azcopy instead of blobxfer and entire Storage Account access
key.

Ref:
-
jenkins-infra/helpdesk#3809 (comment)
@lemeurherve
Copy link
Member

Here we are, https://contributors.jenkins.io is alive!

@krisstern
Copy link
Member Author

Thanks @lemeurherve and team for making this happen!

@kmartens27
Copy link
Collaborator

Thank you so much @lemeurherve and everyone for making this possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants