-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use asdf for node and ruby so .node-version and .ruby-version works #34
Conversation
Dockerfile
Outdated
# node.js sites, e.g. pluginsite | ||
nodejs=~16 \ | ||
npm=~8 | ||
gcompat=~1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we’re doing this we may as well just switch to Debian base right?
PR looks great apart from that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be my vote as well, but I wanted to push what I had so someone else could take a look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note when I tried using this image built locally. Without gcompat node wouldn't run. After adding it, node ran but wouldn't create directories or files for nom install.
May want to tell the asdf plugin to node build instead of gcompat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 🥳
That is a trigger to use debian base (docker-packaging might be a good startup point), but let's start with this one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job buddy!
@@ -98,7 +106,21 @@ COPY --from=img /usr/bin/img /usr/bin/img | |||
COPY --from=img /usr/bin/newuidmap /usr/bin/newuidmap | |||
COPY --from=img /usr/bin/newgidmap /usr/bin/newgidmap | |||
|
|||
# Jenkins.io specifically needs 1.17.3 and multiple versions can be installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.17.3 of what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<_< bundler i think, that was really old comment I missed.
see jenkins-infra/helpdesk#4 for more context