Use asdf for node and ruby so .node-version and .ruby-version works #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Jan 5, 2022
Dockerfile
Outdated
| # node.js sites, e.g. pluginsite | ||
| nodejs=~16 \ | ||
| npm=~8 | ||
| gcompat=~1 |
There was a problem hiding this comment.
If we’re doing this we may as well just switch to Debian base right?
PR looks great apart from that
There was a problem hiding this comment.
that would be my vote as well, but I wanted to push what I had so someone else could take a look at it.
There was a problem hiding this comment.
Note when I tried using this image built locally. Without gcompat node wouldn't run. After adding it, node ran but wouldn't create directories or files for nom install.
May want to tell the asdf plugin to node build instead of gcompat
dduportal
approved these changes
Jan 5, 2022
timja
reviewed
Jan 6, 2022
| @@ -98,7 +106,21 @@ COPY --from=img /usr/bin/img /usr/bin/img | |||
| COPY --from=img /usr/bin/newuidmap /usr/bin/newuidmap | |||
| COPY --from=img /usr/bin/newgidmap /usr/bin/newgidmap | |||
|
|
|||
| # Jenkins.io specifically needs 1.17.3 and multiple versions can be installed | |||
There was a problem hiding this comment.
<_< bundler i think, that was really old comment I missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see jenkins-infra/helpdesk#4 for more context