This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Set up module patching and use patched promise-request-retry to get retry with exponential backoff #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While a few PRs are in flight, we can move forward without needing to go through an even heavier fork. void666/request-promise-retry#6
batmat
changed the title
rtyler
reviewed
Sep 14, 2018
| @@ -7,7 +7,8 @@ | |||
| "client": "node src/client.js", | |||
| "test": "npm run eslint && npm run jest", | |||
| "eslint": "eslint src/. test/. --config .eslintrc.json", | |||
| "jest": "jest" | |||
| "jest": "jest", | |||
| "prepare": "patch-package" | |||
There was a problem hiding this comment.
This should be executed in the Makefile shouldn't it?
There was a problem hiding this comment.
It's done automatically. Because the patching is bound to the standard 'prepare' script.
BTW that is also why I added the associated test: to check and show this does get applied.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a few PRs are in flight, we can move forward without needing to go through an even heavier fork process.
Integrates void666/request-promise-retry#6 and void666/request-promise-retry#5 while they're not merged & released yet.