Remove custom logger #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though nice looking, I do not think that `request-promise-retry` should be configuring a custom logging. Possibly, it could still keep a prefix for its logs, but IMO it should not define specific rules. The application using this nice library is the place to customize logging. First time I realized this and was surprising is when I had bumped the min log level to say warn, and was still seeing the retry related logs coming from here.
|
I would think @coveralls is wrong. How can removing a file lower the coverage? I think it's probably confused in its calculation by the reduction in number of lines and there's a bug there? |
|
@void666 any chance to review and merge this? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow also following up on #1 (comment)
Though nice looking, I do not think that
request-promise-retryshould be configuring a custom logging.Possibly, it could still keep a prefix for its logs, but IMO it should not define specific rules.
The application using this nice library is the place to customize logging.
First time I realized this and was surprising is when I had bumped the min log level to say warn, and was still seeing the retry related logs coming from here.
Thank you!