Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use temurin 8 docker image #120

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Use temurin 8 docker image #120

merged 3 commits into from
Oct 13, 2022

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Oct 12, 2022 •
edited
Loading

I can't locate the current image on the docker hub, the change proposed uses temurin builds.

[2022-10-12T21:42:21.576Z] manifest for java:openjdk-8-jre-alpine not found: manifest unknown: manifest unknown

slide
slide approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@slide slide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look at upgrading to at least Java 11 at some point.

@NotMyFault
Copy link
Member Author

We should look at upgrading to at least Java 11 at some point.

Every project, that invokes the Jenkins Jira API is a nightmare to upgrade 🥴

@timja
Copy link
Member

timja commented Oct 12, 2022

We should look at upgrading to at least Java 11 at some point.

Every project, that invokes the Jenkins Jira API is a nightmare to upgrade 🥴

Ha yup I've hit that before, generally you can drop that dep and use the client directly but the atlassian client isn't great.
From memory they switch from Jax-WS to REST at some point but I wasn't able to figure out how to port some functionality in the last project I tried this in, (rpu maybe?)

@NotMyFault
Copy link
Member Author

Yeah, also used for the RPU, but hey, after my changes today, the RPU's minimum Java version is now Java 11 👏🏻

@NotMyFault NotMyFault requested a review from timja October 12, 2022 22:13
@NotMyFault
Copy link
Member Author

NotMyFault commented Oct 12, 2022 •
edited
Loading

Requested your review, slide's doesn't suffice to merge this pr, according to GH.

dduportal
dduportal previously requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea !

We must stick to a JRE (as it is a production image)

Dockerfile Outdated Show resolved Hide resolved
@NotMyFault @dduportal
Update Dockerfile
ff03633 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
dduportal approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@dduportal dduportal merged commit 45f36fd into jenkins-infra:main Oct 13, 2022
@dduportal dduportal mentioned this pull request Oct 13, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slide slide slide approved these changes

@dduportal dduportal dduportal approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NotMyFault @timja @slide @dduportal