Make new teams visible to org members

[timja]

Requires hub4j/github-api#683

Ref: https://groups.google.com/d/msg/jenkinsci-dev/U_lFkTzmg1E/S-5Q7IVdBQAJ

This PR does:

1. New teams created will be 'visible' (org members can see them and they show up in the reviewers list if CODEOWNERS are used)
2. All users in the HOSTING request will be made a 'Maintainer' of the GH team
3. Adds a new command for making a secret team visible
4. Adds a command to add a user as a maintainer of a team

Docs: jenkins-infra/jenkins.io#2802

[timja]

some conflict when running the latest version, getting a repository that didn't exist seemed to go into an infinite loop.

couldn't find the conflict, but this fixed it

[slide]

The only thing I am not sure about is making the first listed person the maintainer. We need to make sure people filling the hosting requests know this very clearly.

[timja]

Description on the field? Wasn’t sure about making everyone maintainers so just left it as the first one

[timja]

Documentation: jenkins-infra/jenkins.io#2802

[slide]

Description on the field? Wasn’t sure about making everyone maintainers so just left it as the first one

I think we should make everyone maintainers, or else have a separate field for the maintainer so it is very explicit. I just foresee having to clean up a bunch of this when people don't read or understand what it means.

[timja]

Description on the field? Wasn’t sure about making everyone maintainers so just left it as the first one

I think we should make everyone maintainers, or else have a separate field for the maintainer so it is very explicit. I just foresee having to clean up a bunch of this when people don't read or understand what it means.

Happy to implement either,

Do you have a preference? / anyone else?

also cc @batmat since you're also in the hosting team (can't seem to request a review from you)

[timja]

Description on the field? Wasn’t sure about making everyone maintainers so just left it as the first one

I think we should make everyone maintainers, or else have a separate field for the maintainer so it is very explicit. I just foresee having to clean up a bunch of this when people don't read or understand what it means.

Implemented everyone as a maintainer

[olblak]

I think we should make everyone maintainers, or else have a separate field for the maintainer so it is very explicit. I just foresee having to clean up a bunch of this when people don't read or understand what it means.

What would be the risk of things we couldn't revert if everybody was a maintainer?
Considering that the repository are public anyway.

[timja]

We can always downgrade if required, maintainer required that the user is on the org already they can’t send out invites but it’s very useful for teams of people who have multiple plugins or people who have multiple plugins in general

[slide]

My merge of master messed something up, I'll look at it in a bit.

[timja]

GitHub api version mismatch I think, will fix soon

[slide]

@oleg-nenashev Any issues with this?

[olblak]

@timja Can you look at the file conflict? then we can merge this Pr

[timja]

Done @olblak