Do not escape the '#' in Starting & Accessing redirect #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'NE' flag is used successfully with the other URL in the rewrite which uses an ID inside the page. Use it here as well.
|
Yea, there's no querystring or regex capture that could potentially do harm or anything. I think its a safe thing to do Docs - https://httpd.apache.org/docs/2.4/rewrite/flags.html#flag_ne |
halkeye
approved these changes
Apr 28, 2020
olblak
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'NE' flag (RewriteRule flag) is used successfully with the other URL in the rewrite which uses an ID inside the page. Use it here as well.
Fixes jenkins.io issue 3097
@halkeye could you review this to confirm that it is safe to use the same technique for "Starting and Accessing Jenkins" as is used for "Disabling Security"?