Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBSITE-683] - Revamp the participate/review-changes page #2654

Merged
merged 2 commits into from
Nov 18, 2019
Merged

[WEBSITE-683] - Revamp the participate/review-changes page #2654

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6475449
[WEBSITE-683] - Revamp the participate/review-changes page
oleg-nenashev Nov 15, 2019
e1f2542
Apply suggestions from code review
oleg-nenashev Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions content/participate/review-changes.adoc
View file
Open in desktop
Expand Up @@ -9,15 +9,15 @@ tags:
---

Help us to review changes to code or documentation!
All pull requests within Jenkins GitHub organizations are publicly open for reviews, and any reviews will be much appreciated.
All pull requests within Jenkins GitHub organizations are publicly open for reviews and any reviews are much appreciated.

== Code Reviews and Copy Editing

Contributors and component maintainers may explicitly request request reviews from other community members.
Below there are some queries which can help to find such open pull requests where help is needed:
Contributors and component maintainers may explicitly request reviews from other community members.
Below there are some queries which can help to find open pull requests where help is needed:

- link:https://github.com/search?q=is%3Aopen+is%3Apr+team-review-requested%3Ajenkins-infra%2Fcopy-editors[Open pull requests for copy editing], mostly for Jenkins website
- link:https://github.com/search?q=is%3Aopen+is%3Apr+%22jenkinsci%2Fcode-reviewers%22&type=Issues[Open pull requests for code reviews] (https://github.com/orgs/jenkinsci/teams/code-reviewers[@jenkinsci/code-reviewers] team is mentioned)
- link:https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+is%3Aopen+is%3Apr+team-review-requested%3Ajenkins-infra%2Fcopy-editors[Open pull requests for copy editing], mostly for Jenkins website
- link:https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+is%3Aopen+is%3Apr+%22jenkinsci%2Fcode-reviewers%22&type=Issues[Open pull requests for code reviews] (https://github.com/orgs/jenkinsci/teams/code-reviewers[@jenkinsci/code-reviewers] team is mentioned)
- link:https://github.com/search?q=is%3Aopen+is%3Apr+%22jenkinsci%core-pr-reviewers%22&type=Issues[Open pull requests for code reviews in the Jenkins Core] (https://github.com/orgs/jenkinsci/teams/core-pr-reviewers[@jenkinsci/core-pr-reviewers] team is mentioned)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the URL in this search needs to be:

https://github.com/search?q=org%3Ajenkinsci+is%3Aopen+is%3Apr+is%3Apr+team-review-core-pr-reviewers

Since that URL is unmodified by this pull request, I'm approving. Thanks for the pull request.


*NOTE:* You will only be able to see the linked teams if you belong to the corresponding GitHub Team.
Expand Down