[WEBSITE-683] - Revamp the participate/review-changes page #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
requested changes
Nov 15, 2019
Co-Authored-By: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
reviewed
Nov 15, 2019
| - link:https://github.com/search?q=is%3Aopen+is%3Apr+team-review-requested%3Ajenkins-infra%2Fcopy-editors[Open pull requests for copy editing], mostly for Jenkins website | ||
| - link:https://github.com/search?q=is%3Aopen+is%3Apr+%22jenkinsci%2Fcode-reviewers%22&type=Issues[Open pull requests for code reviews] (https://github.com/orgs/jenkinsci/teams/code-reviewers[@jenkinsci/code-reviewers] team is mentioned) | ||
| - link:https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+is%3Aopen+is%3Apr+team-review-requested%3Ajenkins-infra%2Fcopy-editors[Open pull requests for copy editing], mostly for Jenkins website | ||
| - link:https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+is%3Aopen+is%3Apr+%22jenkinsci%2Fcode-reviewers%22&type=Issues[Open pull requests for code reviews] (https://github.com/orgs/jenkinsci/teams/code-reviewers[@jenkinsci/code-reviewers] team is mentioned) | ||
| - link:https://github.com/search?q=is%3Aopen+is%3Apr+%22jenkinsci%core-pr-reviewers%22&type=Issues[Open pull requests for code reviews in the Jenkins Core] (https://github.com/orgs/jenkinsci/teams/core-pr-reviewers[@jenkinsci/core-pr-reviewers] team is mentioned) |
There was a problem hiding this comment.
I think the URL in this search needs to be:
https://github.com/search?q=org%3Ajenkinsci+is%3Aopen+is%3Apr+is%3Apr+team-review-core-pr-reviewers
Since that URL is unmodified by this pull request, I'm approving. Thanks for the pull request.
MarkEWaite
approved these changes
Nov 15, 2019
|
Will finish the fixes tonight
…On Fri, Nov 15, 2019, 20:07 Mark Waite ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2654?email_source=notifications&email_token=AAW4RIHF3IIP6ICSKKW4OULQT3XNPA5CNFSM4JN3MZTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLYW2XQ#pullrequestreview-317812062>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIGPYUY5PH3QIZ5KNS3QT3XNPANCNFSM4JN3MZTA>
.
|
|
I will fix the remaining link in a follow-up. The new links at least discover something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Now: