Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBSITE-683] - Revamp the participate/review-changes page #2654

Merged
merged 2 commits into from
Nov 18, 2019
Merged

[WEBSITE-683] - Revamp the participate/review-changes page #2654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6475449
[WEBSITE-683] - Revamp the participate/review-changes page
oleg-nenashev Nov 15, 2019
e1f2542
Apply suggestions from code review
oleg-nenashev Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 18 additions & 9 deletions content/participate/review-changes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,30 @@ tags:
- review
---

NOTE: This page is under development, there will be more content added soon.
See the jira:WEBSITE-662[] EPIC for tasks related to this page, contributions are welcome!

Help us to review changes to code or documentation!
All pull requests within Jenkins GitHub organizations are publicly open for reviews and any reviews are much appreciated.

== Code Reviews and Copy Editing

You can help review changes to the code and the documentation through following lists:
Contributors and component maintainers may explicitly request reviews from other community members.
Below there are some queries which can help to find open pull requests where help is needed:

- link:https://github.com/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+team%3Ajenkinsci%2Fcode-reviewers[Open pull requests for code reviews]
- link:https://github.com/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+team%3Ajenkins-infra%2Fcopy-editors[Open pull requests for copy editing]
- link:https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+is%3Aopen+is%3Apr+team-review-requested%3Ajenkins-infra%2Fcopy-editors[Open pull requests for copy editing], mostly for Jenkins website
- link:https://github.com/search?q=org%3Ajenkinsci+org%3Ajenkins-infra+is%3Aopen+is%3Apr+%22jenkinsci%2Fcode-reviewers%22&type=Issues[Open pull requests for code reviews] (https://github.com/orgs/jenkinsci/teams/code-reviewers[@jenkinsci/code-reviewers] team is mentioned)
- link:https://github.com/search?q=is%3Aopen+is%3Apr+%22jenkinsci%core-pr-reviewers%22&type=Issues[Open pull requests for code reviews in the Jenkins Core] (https://github.com/orgs/jenkinsci/teams/core-pr-reviewers[@jenkinsci/core-pr-reviewers] team is mentioned)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the URL in this search needs to be:

https://github.com/search?q=org%3Ajenkinsci+is%3Aopen+is%3Apr+is%3Apr+team-review-core-pr-reviewers

Since that URL is unmodified by this pull request, I'm approving. Thanks for the pull request.


*NOTE:* You will only be able to see the open pull requests linked above if you belong to the corresponding GitHub Team.
*NOTE:* You will only be able to see the linked teams if you belong to the corresponding GitHub Team.

== Reviewer team membership

If you are interested to join the link:https://[*Copy Editors team*] or link:https://[*Code Reviewers team*], you can request membership in the link:https://groups.google.com/forum/#!forum/jenkinsci-dev[Jenkins Developer mailing list].
Such membership requires a track of contributions to Jenkins, and also a signed link:https://github.com/jenkinsci/infra-cla[Contributor License Agreement].
If you are interested to join a reviewers team,
you can request membership in the link:https://groups.google.com/forum/#!forum/jenkinsci-dev[Jenkins Developer mailing list].
You can also request membership in the GitHub web interface if you are already a member of a retrospective GitHub organization.
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved

Reviewer team links:

* link:https://github.com/orgs/jenkins-infra/teams/copy-editors[Copy Editors team] - Jenkins website and documentation hosted there
* link:https://github.com/orgs/jenkinsci/teams/code-reviewers[Code Reviewers team] - Jenkins plugins and other components
* link:https://github.com/orgs/jenkinsci/teams/core-pr-reviewers[Core Reviewers team] - Jenkins Core and its modules/libraries

Membership in all teams requires a track of contributions to Jenkins, and also a signed link:https://github.com/jenkinsci/infra-cla[Contributor License Agreement].