Use cards for solutions page #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
documentation
|
I personally love this |
timja
approved these changes
Apr 19, 2020
content/solutions/index.html.haml
Outdated
| min-height: 3rem; | ||
| } | ||
| .card img { | ||
| height:96px; |
There was a problem hiding this comment.
Would be nice to have spacing consistent for css normally one space after the :. Harder for IDE and linter because it’s embedded in Haml I assume
|
It is definitely better than the original version 👍
Thanks!
…On Sun, Apr 19, 2020, 23:16 Tim Jacomb ***@***.***> wrote:
***@***.**** approved this pull request.
I like it
------------------------------
In content/solutions/index.html.haml
<#3082 (comment)>
:
> ---
-%ul
- - site.solutions.keys.sort.each do |key|
+:css
+ .card h3 {
+ font-size: 1.3rem;
+ min-height: 3rem;
+ }
+ .card img {
+ height:96px;
Would be nice to have spacing consistent for css normally one space after
the :. Harder for IDE and linter because it’s embedded in Haml I assume
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3082 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RICQQOQP4MCIQZ4H5F3RNNS3NANCNFSM4ML5M7GA>
.
|
|
Looks really good :) |
oleg-nenashev
approved these changes
Apr 20, 2020
, thanks 
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cards for https://jenkins.io/solutions/ (reusing some styles from https://jenkins.io/participate/ and icons from https://simpleicons.org/ )
@oleg-nenashev WDYT?