Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand upon serializability best practices in pipeline docs #3374

Merged
merged 3 commits into from
May 28, 2020

Conversation

steven-terrana
Copy link
Contributor

No description provided.

@steven-terrana steven-terrana requested a review from a team as a code owner May 27, 2020 17:43
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label May 27, 2020
@steven-terrana
Copy link
Contributor Author

@MarkEWaite

@MarkEWaite MarkEWaite self-assigned this May 27, 2020
@oleg-nenashev
Copy link
Contributor

Thank you for this contribution! It is much appreciated.

Are you doing it as a part of the Jenkins UI/UX Hackfest? If so, please consider reporting this contribution here so that we could facilitate reviews and share the story 👍

@steven-terrana
Copy link
Contributor Author

@oleg-nenashev i am now! i'll report the contribution and i'll update it to a sentence per line.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to assure we retain the old id for the Using NonCPS heading if we can, but not a blocking comment.

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@steven-terrana
Copy link
Contributor Author

Thoughtful comment. thanks Mark! committed your suggestion

@MarkEWaite MarkEWaite merged commit 54166cf into jenkins-infra:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants