-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bootstrap to 5.2, replace Tether with Popper #5436
Conversation
I'm not against it, and i like upgrading, but I'm curious why. I'm also wondering how much it'll break plugins and stories site. |
Main motivation is to allow dark/light mode in the future; the way to implement that changes between Bootstrap 4 and 5 so I figured updating Bootstrap first would be nice. |
It's not pixel-perfect, but I think it's ready for review now. CC @janfaracik @uhafner @MarkEWaite @daniel-beck |
@halkeye gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing stands out to me
@MarkEWaite OK to merge? |
I navigated many different pages on the prototype site and did not detect any issues. I confirmed that the roadmap hover text is available again with this change and that there are many links in the site that jump to https://www.jenkins.io/ when they should instead jump to '/'. I navigated through security advisories and tutorials and pipeline steps reference and roadmap without detecting any issues. Ready to merge. Thanks! |
…infra#5436)" Drop-down menus were not appearing when I clicked the button at the top of the page for "Documentation", "Community", "Subprojects", and "About". This reverts commit 8cfb4a8.
…infra#5436) (jenkins-infra#5716) (jenkins-infra#5722)" The Jumbotron stopped rotating after this commit. This commit is only needed if @zbynek is unable to resolve the issue before 26 Jan 2023. jenkins-infra#5911 is fixed by this revert. This reverts commit 9533704.
I tried keeping the styles of the curent website. The roadmap tooltips stopped working at some point, this PR fixes them.