Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bootstrap to 5.2, replace Tether with Popper #5436

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Update Bootstrap to 5.2, replace Tether with Popper #5436

merged 6 commits into from
Nov 22, 2022

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Sep 11, 2022

I tried keeping the styles of the curent website. The roadmap tooltips stopped working at some point, this PR fixes them.

@zbynek zbynek requested review from a team as code owners September 11, 2022 08:02
@probot-autolabeler probot-autolabeler bot added chore governance roadmap The change is related to the public roadmap. https://jenkins.io/project/roadmap/ labels Sep 11, 2022
@zbynek zbynek marked this pull request as draft September 11, 2022 08:02
@zbynek zbynek marked this pull request as ready for review September 11, 2022 08:40
@halkeye
Copy link
Member

halkeye commented Sep 11, 2022

I'm not against it, and i like upgrading, but I'm curious why.

I'm also wondering how much it'll break plugins and stories site.

@zbynek
Copy link
Contributor Author

zbynek commented Sep 11, 2022

Main motivation is to allow dark/light mode in the future; the way to implement that changes between Bootstrap 4 and 5 so I figured updating Bootstrap first would be nice.

This was referenced Sep 11, 2022
Closed
Closed
@zbynek
Copy link
Contributor Author

zbynek commented Sep 13, 2022

It's not pixel-perfect, but I think it's ready for review now. CC @janfaracik @uhafner @MarkEWaite @daniel-beck

@zbynek
Copy link
Contributor Author

zbynek commented Nov 8, 2022

@halkeye gentle ping

halkeye
halkeye approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@halkeye halkeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing stands out to me

@zbynek
Copy link
Contributor Author

zbynek commented Nov 11, 2022

@MarkEWaite OK to merge?

@MarkEWaite
Copy link
Contributor

I navigated many different pages on the prototype site and did not detect any issues. I confirmed that the roadmap hover text is available again with this change and that there are many links in the site that jump to https://www.jenkins.io/ when they should instead jump to '/'. I navigated through security advisories and tutorials and pipeline steps reference and roadmap without detecting any issues.

Ready to merge. Thanks!

@MarkEWaite MarkEWaite merged commit 8cfb4a8 into jenkins-infra:master Nov 22, 2022
@zbynek zbynek deleted the bootstrap-5 branch November 22, 2022 02:40
MarkEWaite added a commit to MarkEWaite/jenkins.io that referenced this pull request Nov 22, 2022
@MarkEWaite
Revert "Update Bootstrap to 5.2, replace Tether with Popper (jenkins-…
f097108 
…infra#5436)"

Drop-down menus were not appearing when I clicked the button at the top of the
page for "Documentation", "Community", "Subprojects", and "About".

This reverts commit 8cfb4a8.
MarkEWaite added a commit that referenced this pull request Nov 22, 2022
@MarkEWaite
Revert "Update Bootstrap to 5.2, replace Tether with Popper (#5436)" (#…
8244e4c 
…5716)

Drop-down menus were not appearing when I clicked the button at the top of the
page for "Documentation", "Community", "Subprojects", and "About".

This reverts commit 8cfb4a8.
zbynek added a commit to zbynek/jenkins.io that referenced this pull request Nov 22, 2022
@zbynek
Revert "Revert "Update Bootstrap to 5.2, replace Tether with Popper (j…
c704899 
…enkins-infra#5436)" (jenkins-infra#5716)"

This reverts commit 8244e4c.
MarkEWaite pushed a commit that referenced this pull request Nov 22, 2022
@zbynek
Update Bootstrap to 5.2, replace Tether with Popper (#5436) (#5716) (#…
9533704 
…5722)

This reverts commit 8244e4c.
@timja timja mentioned this pull request Nov 22, 2022
Closed
@Vandit1604 Vandit1604 mentioned this pull request Jan 12, 2023
Closed
MarkEWaite added a commit to MarkEWaite/jenkins.io that referenced this pull request Jan 13, 2023
@MarkEWaite
Revert "Update Bootstrap to 5.2, replace Tether with Popper (jenkins-…
93d5226 
…infra#5436) (jenkins-infra#5716) (jenkins-infra#5722)"

The Jumbotron stopped rotating after this commit.  This commit is only
needed if @zbynek is unable to resolve the issue before 26 Jan 2023.

jenkins-infra#5911 is fixed by
this revert.

This reverts commit 9533704.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halkeye halkeye halkeye approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore governance roadmap The change is related to the public roadmap. https://jenkins.io/project/roadmap/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zbynek @halkeye @MarkEWaite