Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Guice 6.x Upgrade to 2.401.2 #6901

Merged
merged 3 commits into from Dec 2, 2023
Merged

Conversation

sghill
Copy link
Contributor

@sghill sghill commented Dec 1, 2023

Hi,

I noticed looking at the changelog-lts that the first mention of Guice 6.x (and jakarta.inject) was in Jenkins 2.414.1.

The first LTS release using Guice 6.x was in 2.401.2 (jenkinsci/jenkins#8121 | discussion).

Interested in updating this because I'd like to link to it while sending PRs from the OpenRewrite Jenkins modernization recipe: openrewrite/rewrite-jenkins#53

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor change that I'll apply

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
@MarkEWaite MarkEWaite enabled auto-merge (squash) December 2, 2023 00:10
@sghill
Copy link
Contributor Author

sghill commented Dec 2, 2023

Thanks @MarkEWaite! Looks like I inadvertently put this in 2.414.2 instead of under 2.401.2 (preview).

Can I push another commit now?

@MarkEWaite
Copy link
Contributor

Thanks @MarkEWaite! Looks like I inadvertently put this in 2.414.2 instead of under 2.401.2 (preview).

Can I push another commit now?

That would be great. I had just detected the same thing and was about to push. You go ahead.

@MarkEWaite MarkEWaite enabled auto-merge (squash) December 2, 2023 00:26
@MarkEWaite MarkEWaite merged commit 3b7ee63 into jenkins-infra:master Dec 2, 2023
6 of 9 checks passed
@MarkEWaite
Copy link
Contributor

@sghill I think that we moved one too many items.

The javax.inject to jakarta.inject did not happen until 2.408. It was not backported to any 2.401.x release

The Guice 6.x upgrade was backported to 2.401.2 in:

I'll submit a revision proposing the change.

@sghill
Copy link
Contributor Author

sghill commented Dec 2, 2023

Ah, sorry about that Mark! Thanks for diving into this and letting me know.

@MarkEWaite
Copy link
Contributor

Ah, sorry about that Mark! Thanks for diving into this and letting me know.

Thanks for your work on OpenRewrite!

@MarkEWaite
Copy link
Contributor

#6902 submitted

@sghill
Copy link
Contributor Author

sghill commented Dec 2, 2023

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Jenkins changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants