New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Guice 6.x Upgrade to 2.401.2 #6901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One minor change that I'll apply
Thanks @MarkEWaite! Looks like I inadvertently put this in 2.414.2 instead of under 2.401.2 (preview). Can I push another commit now? |
That would be great. I had just detected the same thing and was about to push. You go ahead. |
@sghill I think that we moved one too many items. The javax.inject to jakarta.inject did not happen until 2.408. It was not backported to any 2.401.x release The Guice 6.x upgrade was backported to 2.401.2 in: I'll submit a revision proposing the change. |
Ah, sorry about that Mark! Thanks for diving into this and letting me know. |
Thanks for your work on OpenRewrite! |
#6902 submitted |
Looks great! |
Hi,
I noticed looking at the changelog-lts that the first mention of Guice 6.x (and
jakarta.inject
) was in Jenkins 2.414.1.The first LTS release using Guice 6.x was in 2.401.2 (jenkinsci/jenkins#8121 | discussion).
Interested in updating this because I'd like to link to it while sending PRs from the OpenRewrite Jenkins modernization recipe: openrewrite/rewrite-jenkins#53