Move from javax.inject to jakarta.inject

[basil]

Without dropping support for javax.inject annotations, prefer jakarta.inject annotations in our own code wherever possible to facilitate eventually removing support for javax.inject when we move to Guice 7.

Testing done

mvn clean verify -Dtest=hudson.ExtensionFinderTest,jenkins.bugs.Jenkins19124Test,jenkins.install.InstallUtilTest,lib.form.TextAreaTest

Proposed changelog entries

Add support for jakarta.inject annotations.

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[NotMyFault]

Oh, that's nice

[res0nance]

LGTM. Should we leave a javax.inject test in ExtensionFinderTest to ensure we don't accidentally break this?

[NotMyFault]

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[jtnord]

FYI this is a breaking API change because the public extension point uses Provider in its API.

public abstract InstallState getNextInstallState(InstallState current, Provider<InstallState> proceed);

[basil]

Sorry, I had not noticed that before, but you are right. Fortunately I could not find any affected open source plugins, and only a small handful of CloudBees plugins appear to be affected: bluesteel, cloudbees-license-plugin, and cloudbees-assurance-plugin. Since the migration is so easy (just change the imports) I am inclined to leave this as-is in both weeklies and LTS. Since we have to switch to Jakarta injection imports eventually to get to Guice 7, I believe that the benefits of releasing a version with full support for Jakarta injection imports (allowing us to eventually get to Guice 7) outweigh the small cost of adapting to this minor method signature change in a small handful of proprietary plugins. Feel free to let me know if this isn't feasible for some reason.