Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default JDK version #640

Closed
wants to merge 1 commit into from
Closed

Conversation

jetersen
Copy link
Contributor

@jetersen jetersen commented Apr 7, 2023

JDK 11 have been required as the default for newer plugins at what time is it good thing to switch this here in the buildPlugin?

It's been 4 almost 5 months since blog post about JDK 11

https://www.jenkins.io/blog/2022/12/14/require-java-11/

@jetersen jetersen requested a review from a team April 7, 2023 13:42
@lemeurherve
Copy link
Member

lemeurherve commented Apr 7, 2023

See the comments on #514

Doing that would require batch updates of every plugin's Jenkinsfile first for not breaking them with this default value change. (planned)

@MarkEWaite
Copy link
Contributor

As far as I can tell as a first approximation, that change will break 600 of the 1150+ plugins that have a Jenkinsfile. I think it is much better to submit the pull requests to the individual plugins proposing to make their use of Java 8 explicit.

As a different question, is there enough benefit to the Jenkins project to make this change ever? I agree that plugins should be moving to require Jenkins 2.361.4 or newer and should require Java 11, but that is a long process that will take years.

Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in #514.

@MarkEWaite
Copy link
Contributor

I'm closing this pull request because we'd rather retain compatibility for existing users and place the changes into the callers. It can be reopened if we find the need in the future.

@MarkEWaite MarkEWaite closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants