feat(publishReports): add failIfEmpty parameter
#853
Conversation
Can you revert this change please? having this particular operations ( |
| lineCount=$(wc -l "${filename}" | awk '{print $1}') | ||
| if [[ "${failIsEmpty}" != false && "${lineCount}" -eq 0 ]]; then | ||
| echo "ERROR: ${filename} is empty." | ||
| exit 1 |
There was a problem hiding this comment.
Fundamental question: do we want the calling pipeline to fail? At first sight it looks like but since the only known use case today is jenkins-infra/helpdesk#4056 then I'm asking.
Is the condition (and its maintenance burden: it is not even tested since it is implemented with shell code) worth the gain considering PHS reports are now always generated?
There was a problem hiding this comment.
So... rename this PR and change failIfEmpty by skipIfEmpty?
I propose to remove the |
|
Closing as per the proposal in #853 (comment) |
FWIW this proposal was a response to #853 (comment), not a proposal to close this PR. |
Ack. it was not clear to me. I'm reopening this PR but it has to be worked on or closed for no activity: having a draft PR with no work opened for weeks shows maintainers cannot afford working on a given subject. Closing such PRs shows we acknowledge this and we can focus our effort on something else. |
I agree, but last two weeks I was in PTO so really there has been only 4 working days elapsed since our last exchange on this PR, which is not a lot. |
I understand but it's not only about your schedule, as PR author, but also about the maintainers of this repository and the team planning. Not mentioning the production risks: worth raising the topic as an issue for the infra since the infra team (including you) will have to plan this change and validate how to verify how and if it works as expected. Consequence of such a change are a large scope. |
|
Closing as there is no immediate need for this feature. |
This PR adds an optional
failIfEmptyparameter to fail the call topublishReportsif the file to upload is empty. (To avoid erasing an existing report for example).The value of this parameter is set to false by default to keep the current behavior for existing consumers not needing it.
This PR also regroups the two
shblocks into one, and adds braces & double quotes around variables to prevent globbing and words splitting.Ref: