Move Plugin Site Label display names to the update center

[oleg-nenashev]

Currently label display names are stored locally as the Plugin Site API resource: https://github.com/jenkins-infra/plugin-site-api/blob/master/src/main/resources/labels.json . It does not make much sense, and it prevents other consumers from using them.

I suggest moving the display names to https://github.com/jenkins-infra/update-center2 directly

CC @jenkins-infra/plugin-site

[halkeye]

heck yes!

Just make it output a new file that can be cached/consumed?

I don't think changing the main json to return strings is a good plan.

[daniel-beck]

Disagree strongly.

This proposal would bloat update center JSON, downloaded hundreds of thousands of times every day, for very little benefit except during short periods of increased label definition activity, like we're in now. Nobody should be using a Jenkins release with label/category definitions older than 4 months (and that's just LTS due to baseline age), so there's few user-friendly label names people would be missing out on.

[halkeye]

I don't think it needs to be in the json, just owned by update center. labels.json or something. I'm a big fan of static files that can be CDN'd over api servers that can go down

[daniel-beck]

@halkeye That makes (some) sense, but isn't @oleg-nenashev's goal per jenkinsci/jenkins#4534 (comment).

[oleg-nenashev]

Actually I would prefer a separate file as @halkeye says. The tricky part is serving it to Jenkins instances with custom update center. Maybe a build-time update is good enough

[daniel-beck]

The tricky part is serving it to Jenkins instances with custom update center.

IOW,

bloat update center JSON

would still apply.

[halkeye]

Coming back to this one, what about the labels being in jenkins core then, and we render the label name from core, else the tag. That isn't something that updates very often if ever really...

[zbynek]

Since jenkins-infra/plugin-site#754 the label translations come from Core and label categories from plugin-site.