Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plugin release date in plugin manager #4535

Merged
merged 6 commits into from
Mar 5, 2020

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Mar 1, 2020

This was one of the feedbacks at the contributor summit at FOSDEM: It would be helpful to see at a glance when a plugin was released, to help understand how actively it is maintained.

Up to date screenshots in #4535 (comment)

Proposed changelog entries

  • Show plugin release date in plugin manager

Proposed upgrade guidelines

N/A

Submitter checklist

  • [n/a] JIRA issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

@jenkinsci jenkinsci deleted a comment from oleg-nenashev Mar 1, 2020
Copy link
Contributor

@StefanSpieker StefanSpieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a nice feature. Thanks 👍

@timja
Copy link
Member

timja commented Mar 1, 2020

Alignment of the version column seems wrong on the available tab:

image

It's fine on the installed column, and I don't have any plugin updates atm, but I assume it's fine there as that's what is screenshotted

I was also happy to see that the date is localised and I get the date format that I am used to

@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Mar 1, 2020
timja
timja previously requested changes Mar 1, 2020
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #4535 (comment),

should be a minor fix hopefully

@timja
Copy link
Member

timja commented Mar 1, 2020

Hmm taking another look without this change,
it already seems to be misaligned but this makes it worse,

Removing my change requested but I still think it should be improved:

image

@timja timja dismissed their stale review March 1, 2020 09:31

it was already there, although this makes it worse

@daniel-beck
Copy link
Member Author

Alignment of the version column seems wrong on the available tab:

It's due to ridiculously long version numbers like 1.12+build.201809061734 or 3.8.20200204-101107.d1d344b and left-alignment of the column content. Unrelated to this change.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether formatting would differ depending on the user locale, but it is fine even if it is not

@daniel-beck
Copy link
Member Author

I wonder whether formatting would differ depending on the user locale

It does, that's the whole point of using this control.

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
@timja
Copy link
Member

timja commented Mar 1, 2020

I wonder whether formatting would differ depending on the user locale, but it is fine even if it is not

if you see my screenshot it has a different locale to DB's

- Sort independently of sortable.js date parsing magic
- Hide categories when sorting by release date
@daniel-beck
Copy link
Member Author

This now depends on #4534 not being merged before this, or https://github.com/jenkinsci/jenkins/pull/4535/files#diff-6c89c5cced7eb382005a0b0825a45140R70 needs onclick removed otherwise. Should be trivial to do on GitHub and ideally not hold off merging for technicalities.

@fqueiruga
Copy link
Contributor

I know I'm late to the party but I have a suggestion. Can we consider, instead of having another numeric column showing the date, showing the last release as text? That will remove mental load for the user.

We could also show that message within the version column. The information relates to the version anyway. An example:
Captura de pantalla 2020-03-02 a las 10 24 53

@daniel-beck
Copy link
Member Author

We could also show that message within the version column. The information relates to the version anyway.

I considered that, but was unsure how this would impact sorting by this column. Given how useless sort by version is, I guess this column would then sort by release date? Is that useful UX?

@fqueiruga
Copy link
Contributor

If we want to sort by release date, we would definitely need a column just for it IMO

@daniel-beck
Copy link
Member Author

If we want to sort by release date, we would definitely need a column just for it IMO

Well, the table is sortable. Right now it's possible to sort by name and version number (🤣). Sorting by date is potentially the most useful of any of them (even if there's no obvious use case other than something like getting general ecosystem status at a glance).

Anyway, I like your "time span" idea a lot better than just displaying the date. I will implement that. The specific date can always be the tool tip.

@fqueiruga
Copy link
Contributor

May I also suggest using the <time> tag? With tooltip would look something like this <time datetime="2019-08-15" tooltip="15/08/2019">8 months ago</time>.

@daniel-beck
Copy link
Member Author

Updated based on feedback. It now looks like this:

Screenshot 2020-03-02 at 13 34 16
Screenshot 2020-03-02 at 13 37 17

Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@daniel-beck daniel-beck added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 3, 2020
@daniel-beck
Copy link
Member Author

Universal approval, so marking ready-for-merge so this can go into the upcoming weekly.

@timja
Copy link
Member

timja commented Mar 4, 2020

@daniel-beck are you able to resolve the conflicts please?

@timja timja added unresolved-merge-conflict There is a merge conflict with the target branch. and removed ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Mar 4, 2020
@daniel-beck
Copy link
Member Author

*cough* #4535 (comment) *cough* 😁

@daniel-beck daniel-beck added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed unresolved-merge-conflict There is a merge conflict with the target branch. labels Mar 4, 2020
@timja
Copy link
Member

timja commented Mar 4, 2020

Lol, other one had been updated more recently so it was higher in the list, and your comment got buried above many other comments :p

@oleg-nenashev oleg-nenashev merged commit 9537ee5 into jenkinsci:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
7 participants