Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve presentation of plugin categories #4534

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Improve presentation of plugin categories #4534

merged 2 commits into from
Mar 4, 2020

Conversation

daniel-beck
Copy link
Member

  • Show labels/categories in each plugin entry (supporting filtering)
  • Don't have multiple table sections for categories

The grouping into different table sections may have made sense when there were only 100 plugins total, but using the "Available" tab is basically limited to searching/filtering only now. So nobody really saw the categories anymore. While it is due for a larger overhaul, let's start with fixing how categories are shown.

It probably makes sense to add localizations for recently defined whitelisted labels in update-center2 to make it a rare occurrence to see an unlocalized label, but I think it's fine as is.

I'm open to alternative presentation/styling of the categories in the table entries, just propose alternatives.

Screenshots

Available list, filtered by label

Screenshot

Updates list

Screenshot

Proposed changelog entries

  • RFE: Show plugin categories as labels in the plugin manager instead of grouping them into different table sections

Proposed upgrade guidelines

N/A

Submitter checklist

  • [n/a] JIRA issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

@daniel-beck
Improve presentation of plugin categories
060b2c4 
- Show labels/categories in each plugin entry (supporting filtering)
- Don't have multiple table sections for categories
@daniel-beck daniel-beck changed the title Multiple minor improvements to the plugin manager Improve presentation of plugin categories Mar 1, 2020
@oleg-nenashev oleg-nenashev added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Mar 1, 2020
@oleg-nenashev
Copy link
Member

One comment about UX, label display names should probably come from the update center: jenkins-infra/plugin-site-api#82 .Though it keeps a question about custom update centers then

@daniel-beck
Copy link
Member Author

One comment about UX, label display names should probably come from the update center: jenkins-infra/plugin-site-api#82 .Though it keeps a question about custom update centers then

Seems orthogonal to this proposal.

@daniel-beck daniel-beck mentioned this pull request Mar 1, 2020
Closed
@timja
Copy link
Member

timja commented Mar 1, 2020

Could we get a little bit more spacing below the link and above the category? It looks too close to me

@daniel-beck daniel-beck mentioned this pull request Mar 1, 2020
Merged
8 tasks
fqueiruga
fqueiruga reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@fqueiruga fqueiruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd wrap the labels within a div and style said div. I'd also make it as a flex container so that labels would wrap into multiple lines.

Captura de pantalla 2020-03-02 a las 12 35 52

core/src/main/resources/hudson/PluginManager/_table.css Outdated Show resolved Hide resolved
@fqueiruga @daniel-beck
Fix presentation
fc92da0 
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
@daniel-beck
Copy link
Member Author

Updated presentation:

Screenshot
Screenshot

oleg-nenashev
oleg-nenashev approved these changes Mar 3, 2020
View reviewed changes
core/src/main/java/hudson/model/UpdateCenter.java
@@ -2454,6 +2457,7 @@ protected void replace(File dst, File src) throws IOException {
}
}

@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Javadoc would with explanation be nice

core/src/main/java/hudson/model/UpdateCenter.java
@@ -989,7 +989,9 @@ private XmlFile getConfigFile() {
/**
* Returns a list of plugins that should be shown in the "available" tab, grouped by category.
* A plugin with multiple categories will appear multiple times in the list.
* @deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated
* @deprecated No longer used for visualization in the Plugin Manager

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 3, 2020
@oleg-nenashev
Copy link
Member

I plan to merge it tomorrow if no negative feedback

EstherAF
EstherAF approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@EstherAF EstherAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the spacing really made a difference. It looks really nice!

@oleg-nenashev oleg-nenashev mentioned this pull request Mar 3, 2020
Open
@daniel-beck
Copy link
Member Author

daniel-beck commented Mar 3, 2020 •
edited

@EstherAF Agreed, nobody should let me write UI. 😁 I'm glad @fqueiruga is around.

jvz
jvz approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple improvement!

@timja timja merged commit 7dbb592 into jenkinsci:master Mar 4, 2020
This was referenced Mar 14, 2020
Merged
Merged
@basil basil mentioned this pull request Jan 19, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halkeye halkeye halkeye approved these changes

@jvz jvz jvz approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@EstherAF EstherAF EstherAF approved these changes

@fqueiruga fqueiruga fqueiruga approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
7 participants
@daniel-beck @oleg-nenashev @timja @halkeye @jvz @EstherAF @fqueiruga