Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the unleash plugin #6

Merged
merged 1 commit into from Dec 21, 2022

Conversation

MarkEWaite
Copy link
Contributor

Deprecate the unleash plugin

https://github.com/shillner/unleash-maven-plugin/ has been archived. That is the unleash plugin for Apache Maven. The Jenkins unleash maven plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived. That is the Jenkins unleash Maven plugin. The last release of the Jenkins unleash maven plugin was 3 years ago. Since the Jenkins plugin repository has been archived, we can expect no new releases of the plugin.

JENKINS-70326 notes that the Jenkins unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that the Jenkins plugin is not being maintained and that the Apache Maven plugin is not being maintained.

https://www.jenkins.io/doc/developer/plugin-governance/deprecating-or-removing-plugin/ says that the preferred way to deprecate a plugin is to add the "deprecated" topic to the repository and to explain in the plugin documentation why it is being deprecated. That would mean allowing writes to the repository again, just long enough to set the topic.

I assume that is more complicated than the alternate method, a pull request to the update center repository to mark the repository as deprecated.

jenkins-infra/repository-permissions-updater#3042 is the request to remove all developers from the archived plugin repository.

https://github.com/shillner/unleash-maven-plugin/ has been archived.
That is the unleash plugin for Apache Maven.  The Jenkins unleash maven
plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived.  That is
the Jenkins unleash Maven plugin. The last release of the Jenkins unleash
maven plugin was 3 years ago. Since the Jenkins plugin repository has
been archived, we can expect no new releases of the plugin.

[JENKINS-70326](https://issues.jenkins.io/browse/JENKINS-70326) notes
that the Jenkins unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that the
Jenkins plugin is not being maintained and that the Apache Maven plugin
is not being maintained.

https://www.jenkins.io/doc/developer/plugin-governance/deprecating-or-removing-plugin/
says that the preferred way to deprecate a plugin is to add the
"deprecated" topic to the repository and to explain in the plugin
documentation why it is being deprecated.  That would mean allowing
writes to the repository again, just long enough to set the topic.

I assume that is more complicated than the alternate method, a pull
request to the update center repository to mark the repository as
deprecated.

jenkins-infra/repository-permissions-updater#3042
is the request to remove all developers from the archived plugin
repository.
MarkEWaite added a commit to MarkEWaite/update-center2 that referenced this pull request Dec 21, 2022
https://github.com/shillner/unleash-maven-plugin/ has been archived.  That is the unleash plugin for Apache Maven.  The Jenkins unleash maven plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived.  That is the Jenkins unleash Maven plugin. The last release of the Jenkins unleash maven plugin was 3 years ago. Since the Jenkins plugin repository has been archived, we can expect no new releases of the plugin.

https://issues.jenkins.io/browse/JENKINS-70326 notes that the Jenkins unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that the Jenkins plugin is not being maintained and that the Apache Maven plugin is not being maintained.

The [deprecation document](https://www.jenkins.io/doc/developer/plugin-governance/deprecating-or-removing-plugin/) says that the preferred way to deprecate a plugin is to add the "deprecated" topic to the repository and to explain in the plugin documentation why it is being deprecated.  That would mean allowing writes to the repository again, just long enough to set the topic.

I assume that is more complicated than the alternate method, a pull request to the update center repository to mark the repository as deprecated.  I've taken the alternate approach with this pull request.

jenkins-infra/plugins-wiki-docs#6 is the documetnation pull request to mark the plugin as deprecated.
Copy link

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what team has access here?

I would've expected either Core or copy editors to give permissions on this repo

cc @dduportal @lemeurherve

@MarkEWaite
Copy link
Contributor Author

I believe that @halkeye has permissions here

@MarkEWaite MarkEWaite changed the title Deprecate unleash plugin Deprecate the unleash plugin Dec 21, 2022
@halkeye
Copy link
Member

halkeye commented Dec 21, 2022

i do have merge permission. I have no who else does as I'm not an admin.

@halkeye halkeye merged commit 853313f into jenkins-infra:master Dec 21, 2022
@MarkEWaite MarkEWaite deleted the deprecate-unleash-plugin branch April 3, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants