Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70326] Deprecate unleash plugin #3042

Merged
merged 1 commit into from Dec 21, 2022
Merged

[JENKINS-70326] Deprecate unleash plugin #3042

merged 1 commit into from Dec 21, 2022

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Dec 21, 2022

JENKINS-70326 Deprecate unleash plugin

https://github.com/shillner/unleash-maven-plugin/ has been archived. That is the unleash plugin for Apache Maven. The Jenkins unleash maven plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived. That is the Jenkins unleash Maven plugin. The last release of the Jenkins unleash maven plugin was 3 years ago. Since the Jenkins plugin repository has been archived, we can expect no new releases of the plugin.

JENKINS-70326 notes that the Jenkins unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that the Jenkins plugin is not being maintained and that the Apache Maven plugin is not being maintained.

The deprecation document says that the preferred way to deprecate a plugin is to add the "deprecated" topic to the repository and to explain in the plugin documentation why it is being deprecated. That would mean allowing writes to the repository again, just long enough to set the topic.

I assume that is more complicated than the alternate method, a pull request to the update center repository to mark the repository as deprecated. @daniel-beck is it better / easier for me to submit the pull request to the update center or would you prefer that I ask that the repository be temporarily unarchived?

https://github.com/jenkins-infra/plugins-wiki-docs/tree/master/unleash is the documentation for the plugin. I'll submit a pull request to the wiki repository to note that the plugin is deprecated.

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

https://github.com/shillner/unleash-maven-plugin/ has been archived.
That is the unleash plugin for Apache Maven.  The Jenkins unleash
maven plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived.  That
is the Jenkins unleash Maven plugin. The last release of the Jenkins
unleash maven plugin was 3 years ago. Since the Jenkins plugin
repository has been archived, we can expect no new releases of the
plugin.

https://issues.jenkins.io/browse/JENKINS-70326 notes that the Jenkins
unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that
the Jenkins plugin is not being maintained and that the Apache Maven
plugin is not being maintained.

https://www.jenkins.io/doc/developer/plugin-governance/deprecating-or-removing-plugin/
says that the preferred way to deprecate a plugin is to add the
"deprecated" topic to the repository and to explain in the plugin
documentation why it is being deprecated.  That would mean allowing
writes to the repository again, just long enough to set the topic.

I assume that is more complicated than the alternate method, a pull
request to the update center repository to mark the repository as
deprecated.

https://github.com/jenkins-infra/plugins-wiki-docs/tree/master/unleash
is the documentation for the plugin.  I'll submit a pull request to
the wiki repository to note that the plugin is deprecated.
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 21, 2022 13:18
@wborn
Copy link

wborn commented Dec 21, 2022

JENKINS-70326 notes that the Jenkins unleash maven plugin does not work with Java 17.

You can see the error and some discussion about it here:

@NotMyFault
Copy link
Member

I assume that is more complicated than the alternate method, a pull request to the update center repository to mark the repository as deprecated. daniel-beck is it better / easier for me to submit the pull request to the update center or would you prefer that I ask that the repository be temporarily unarchived?

If the upstream service the plugin depends on is no longer maintained, we may also suspend the plugin from the update center, making the deprecation note obsolete 🤔

MarkEWaite added a commit to MarkEWaite/plugins-wiki-docs that referenced this pull request Dec 21, 2022
https://github.com/shillner/unleash-maven-plugin/ has been archived.
That is the unleash plugin for Apache Maven.  The Jenkins unleash maven
plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived.  That is
the Jenkins unleash Maven plugin. The last release of the Jenkins unleash
maven plugin was 3 years ago. Since the Jenkins plugin repository has
been archived, we can expect no new releases of the plugin.

[JENKINS-70326](https://issues.jenkins.io/browse/JENKINS-70326) notes
that the Jenkins unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that the
Jenkins plugin is not being maintained and that the Apache Maven plugin
is not being maintained.

https://www.jenkins.io/doc/developer/plugin-governance/deprecating-or-removing-plugin/
says that the preferred way to deprecate a plugin is to add the
"deprecated" topic to the repository and to explain in the plugin
documentation why it is being deprecated.  That would mean allowing
writes to the repository again, just long enough to set the topic.

I assume that is more complicated than the alternate method, a pull
request to the update center repository to mark the repository as
deprecated.

jenkins-infra/repository-permissions-updater#3042
is the request to remove all developers from the archived plugin
repository.
@MarkEWaite
Copy link
Contributor Author

If the upstream service the plugin depends on is no longer maintained, we may also suspend the plugin from the update center, making the deprecation note obsolete 🤔

As far as I understand it, the Apache Maven unleash plugin is unmaintained but still available. The existing functionality continues to work. Since the existing functionality continues to work, I think that deprecation is more appropriate than suspension.

@timja timja merged commit d82e89f into jenkins-infra:master Dec 21, 2022
@MarkEWaite MarkEWaite deleted the unleash-is-unmaintained branch December 21, 2022 16:23
MarkEWaite added a commit to jenkinsci/unleash-plugin that referenced this pull request Dec 21, 2022
https://github.com/shillner/unleash-maven-plugin/ has been archived.
That is the unleash plugin for Apache Maven.  The Jenkins unleash maven
plugin depends on the unleash plugin for Apache Maven.

https://github.com/jenkinsci/unleash-plugin has been archived.  That is
the Jenkins unleash Maven plugin. The last release of the Jenkins unleash
maven plugin was 3 years ago. Since the Jenkins plugin repository has
been archived, we can expect no new releases of the plugin.

[JENKINS-70326](https://issues.jenkins.io/browse/JENKINS-70326) notes
that the Jenkins unleash maven plugin does not work with Java 17.

Let's deprecate the Jenkins plugin so that it is clear to users that the
Jenkins plugin is not being maintained and that the Apache Maven plugin
is not being maintained.

jenkins-infra/repository-permissions-updater#3042
is the request to remove all developers from the archived plugin
repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants