Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD for build-token-root #2225

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Dec 2, 2021

Description

Seems prudent to try jenkins-infra/jenkins-maven-cd-action#14 on something I own which is not yet set up for JEP-229 metadata (though it is incrementalified) with a smaller “blast radius” than plugin-pom.

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jglick jglick requested a review from a team as a code owner December 2, 2021 18:13
@timja timja merged commit 2cda0f9 into jenkins-infra:master Dec 2, 2021
@jglick jglick deleted the patch-3 branch December 2, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants