Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable continuous delivery for parameterized trigger plugin #3628

Conversation

MarkEWaite
Copy link
Contributor

Enable continuous delivery for parameterized trigger plugin

jenkinsci/parameterized-trigger-plugin#366 is the pull request to enable continuous delivery in the parameterized trigger plugin.

I performed the previous release manually and would rather have the simplification of automated releases since we now have a pending bug fix pull request and a pending enhancement.

Bug fix:

Enhancement:

Link to GitHub repository

jenkinsci/parameterized-trigger-plugin#366 is

When modifying release permission

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist Release permission checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
    Options
  2. All users added have logged in to Artifactory and Jira once.
    Options
  3. I have mentioned an existing team member of the plugin or component team to approve this request.
    Options

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

jenkinsci/parameterized-trigger-plugin#366

CD checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist CD checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I have provided a link to the pull request in my plugin, which enables CD according to the documentation.
    Options

Reviewer checklist

Edit tasklist title
Beta Give feedback Tasklist Reviewer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Check that the $pluginId Developers team has Admin permissions while granting the access.
    Options
  2. In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
    Options
  3. If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
    Options

There are IRC Bot commands for it.

jenkinsci/parameterized-trigger-plugin#366 is
the pull request to enable continuous delivery in the parameterized
trigger plugin.

I performed the previous release manually and would rather have the
simplification of automated releases since we now have a pending bug
fix pull request and a pending enhancement.

Bug fix:

* jenkinsci/parameterized-trigger-plugin#357

Enhancement:

* jenkinsci/parameterized-trigger-plugin#363

I'm not a user of the plugin, so I want to simplfy my contributions to
the plugin so that they will be released automatically.
@MarkEWaite MarkEWaite requested a review from a team as a code owner November 22, 2023 12:58
@NotMyFault NotMyFault enabled auto-merge (squash) November 22, 2023 13:19
@NotMyFault NotMyFault merged commit 4ba4f73 into jenkins-infra:master Nov 22, 2023
3 checks passed
@MarkEWaite MarkEWaite deleted the enable-cd-for-parmeterized-trigger-plugin branch November 22, 2023 13:43
@MarkEWaite
Copy link
Contributor Author

@NotMyFault I've been looking for the secrets to appear in that repository and don't see them. Is it common for that process to need more than 30 minutes to complete?

@MarkEWaite
Copy link
Contributor Author

@NotMyFault I've been looking for the secrets to appear in that repository and don't see them. Is it common for that process to need more than 30 minutes to complete?

And now that I ask the question, they immediately appear. Thanks for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants