Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-71919 Use modern icon class in subproject page #357

Merged
merged 2 commits into from Nov 22, 2023
Merged

JENKINS-71919 Use modern icon class in subproject page #357

merged 2 commits into from Nov 22, 2023

Conversation

gjabouley-invn
Copy link
Contributor

This PR fixes https://issues.jenkins.io/browse/JENKINS-71919

Testing done

mvn -ntp clean verify maven command is successful

Before

before

After

after

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@gjabouley-invn gjabouley-invn requested a review from a team as a code owner October 27, 2023 14:01
@MarkEWaite MarkEWaite added the bug label Nov 22, 2023
@MarkEWaite MarkEWaite mentioned this pull request Nov 22, 2023
Merged
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Nov 22, 2023
@MarkEWaite
Enable continuous delivery for parameterized trigger plugin
c7d0ea8 
jenkinsci/parameterized-trigger-plugin#366 is
the pull request to enable continuous delivery in the parameterized
trigger plugin.

I performed the previous release manually and would rather have the
simplification of automated releases since we now have a pending bug
fix pull request and a pending enhancement.

Bug fix:

* jenkinsci/parameterized-trigger-plugin#357

Enhancement:

* jenkinsci/parameterized-trigger-plugin#363

I'm not a user of the plugin, so I want to simplfy my contributions to
the plugin so that they will be released automatically.
MarkEWaite
MarkEWaite approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 1d07583 into jenkinsci:master Nov 22, 2023
14 checks passed
@mawinter69 mawinter69 mentioned this pull request Nov 25, 2023
Merged
@gjabouley-invn gjabouley-invn deleted the feature/JENKINS-71919 branch December 1, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@gjabouley-invn @MarkEWaite