Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For multimodule plugin added valid path for 2.x ca-apm-plugin #990

Merged
merged 5 commits into from
Jan 18, 2019

Conversation

pramodanarase
Copy link
Contributor

@pramodanarase pramodanarase commented Jan 14, 2019

Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/ca-apm-plugin/2.0-alpha-2/ca-apm-plugin-2.0-alpha-2.pom, ReasonPhrase: Forbidden.

Description

Git repository - https://github.com/jenkinsci/ca-apm-plugin
Git committer : me (@pramodanarase ) and @srikns , also we have release permission on same plugin

Submitter checklist for changing permissions

Always

  • Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

@pramodanarase
Copy link
Contributor Author

@batmat - Can you please look into it?

@pramodanarase
Copy link
Contributor Author

Can any one look into it? We are blocked on this as getting access denied error to upload artifact on artifactory.

@daniel-beck
Copy link
Contributor

This won't work, unfortunately. The script as is does only support a single artifactId per YAML file. The list of paths exist solely to support changing groupId.

You will need to add individual files for all artifacts. See e.g. the files with blueocean in their name.

We're aware this is a bit of a mess, but haven't had the time to address it properly.

@pramodanarase
Copy link
Contributor Author

pramodanarase commented Jan 15, 2019

@batmat and @daniel-beck - i will update root project name from ca-apm-plugin to ca-apm-parent
and will add 6 files ( 5 sub-module and 1 root ) in parallel to permissions/plugin-ca-apm.yml (hpi)
as

  1. plugin-ca-apm-parent.yml (pom)
  2. plugin-ca-apm-api.yml (jar)
  3. plugin-ca-apm-core.yml (jar)
  4. plugin-ca-apm-default-strategy.yml (jar)
  5. plugin-ca-apm-dist.yml (pom +zip)

Do i need to do anything else?

@pramodanarase
Copy link
Contributor Author

@batmat and @daniel-beck - i have added the fix. Please review.

pramodanarase added a commit to jenkinsci/ca-apm-plugin that referenced this pull request Jan 15, 2019
@daniel-beck
Copy link
Contributor

Do i need to do anything else?

Which of these are actual plugins, and which are just POMs or libraries? We use different naming schemes for them, I will update this PR accordingly.

@pramodanarase
Copy link
Contributor Author

pramodanarase commented Jan 16, 2019

@daniel-beck - updated earlier comment
the project structure as:
ca-apm-parent(root pom)
-- ca-apm-api (jar)
-- ca-apm-core (jar)
-- ca-apm-default-strategy (jar)
-- ca-apm (hpi)
-- ca-apm-dist (pom)

@daniel-beck daniel-beck self-assigned this Jan 16, 2019
@pramodanarase
Copy link
Contributor Author

@batmat and @daniel-beck - Can you please look into it?

@batmat
Copy link
Contributor

batmat commented Jan 17, 2019

Also, I think you could want to consider changing the base of your groupId to io.jenkins.plugins, which is becoming the new standard, given IIUC you've changed anyway the plugin quite a lot.

Copy link
Contributor

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

permissions/plugin-ca-apm-api.yml Outdated Show resolved Hide resolved
@batmat
Copy link
Contributor

batmat commented Jan 17, 2019

Given the number of files, I'll leave @daniel-beck make a second pass and merge.
If Daniel cannot do it, I'll merge it soon. Worst case, you'll have to file an adjustment PR.

Thanks for the patience.

@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view
Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/org/apache/maven/plugins/maven-assembly-plugin/2.2.1/maven-assembly-plugin-2.2.1.jar
Progress (1): 0.6/221 kB
Progress (1): 2.0/221 kB
Progress (1): 3.4/221 kB
Progress (1): 4.7/221 kB
Progress (1): 6.1/221 kB
Progress (1): 7.5/221 kB
Progress (1): 8.9/221 kB
Progress (1): 10/221 kB 
Progress (1): 12/221 kB
Progress (1): 13/221 kB
Progress (1): 14/221 kB
Progress (1): 16/221 kB
Progress (1): 17/221 kB
Progress (1): 19/221 kB
Progress (1): 20/221 kB
Progress (1): 21/221 kB
Progress (1): 23/221 kB
Progress (1): 24/221 kB
Progress (1): 25/221 kB
Progress (1): 27/221 kB
Progress (1): 28/221 kB
Progress (1): 29/221 kB
Progress (1): 30/221 kB
Progress (1): 31/221 kB
Progress (1): 33/221 kB
Progress (1): 34/221 kB
Progress (1): 36/221 kB
Progress (1): 37/221 kB
Progress (1): 38/221 kB
Progress (1): 40/221 kB
Progress (1): 41/221 kB
Progress (1): 43/221 kB
Progress (1): 44/221 kB
Progress (1): 45/221 kB
Progress (1): 47/221 kB
Progress (1): 48/221 kB
Progress (1): 50/221 kB
Progress (1): 51/221 kB
Progress (1): 52/221 kB
Progress (1): 53/221 kB
Progress (1): 55/221 kB
Progress (1): 56/221 kB
Progress (1): 58/221 kB
Progress (1): 59/221 kB
Progress (1): 60/221 kB
Progress (1): 62/221 kB
Progress (1): 63/221 kB
Progress (1): 64/221 kB
Progress (1): 65/221 kB
Progress (1): 67/221 kB
Progress (1): 67/221 kB
Progress (1): 68/221 kB
Progress (1): 70/221 kB
Progress (1): 71/221 kB
Progress (1): 73/221 kB
Progress (1): 74/221 kB
Progress (1): 75/221 kB
Progress (1): 77/221 kB
Progress (1): 78/221 kB
Progress (1): 79/221 kB
Progress (1): 81/221 kB
Progress (1): 82/221 kB
Progress (1): 83/221 kB
Progress (1): 85/221 kB
Progress (1): 86/221 kB
Progress (1): 87/221 kB
Progress (1): 89/221 kB
Progress (1): 90/221 kB
Progress (1): 92/221 kB
Progress (1): 93/221 kB
Progress (1): 94/221 kB
Progress (1): 96/221 kB
Progress (1): 97/221 kB
Progress (1): 98/221 kB
Progress (1): 100/221 kB
Progress (1): 101/221 kB
Progress (1): 103/221 kB
Progress (1): 104/221 kB
Progress (1): 105/221 kB
Progress (1): 107/221 kB
Progress (1): 108/221 kB
Progress (1): 109/221 kB
Progress (1): 111/221 kB
Progress (1): 112/221 kB
Progress (1): 113/221 kB
Progress (1): 115/221 kB
Progress (1): 116/221 kB
Progress (1): 118/221 kB
Progress (1): 119/221 kB
Progress (1): 120/221 kB
Progress (1): 122/221 kB
Progress (1): 123/221 kB
Progress (1): 124/221 kB
Progress (1): 126/221 kB
Progress (1): 127/221 kB
Progress (1): 129/221 kB
Progress (1): 130/221 kB
Progress (1): 131/221 kB
Progress (1): 133/221 kB
Progress (1): 134/221 kB
Progress (1): 136/221 kB
Progress (1): 137/221 kB
Progress (1): 138/221 kB
Progress (1): 139/221 kB
Progress (1): 141/221 kB
Progress (1): 142/221 kB
Progress (1): 144/221 kB
Progress (1): 145/221 kB
Progress (1): 146/221 kB
Progress (1): 148/221 kB
Progress (1): 149/221 kB
Progress (1): 150/221 kB
Progress (1): 152/221 kB
Progress (1): 153/221 kB
Progress (1): 154/221 kB
Progress (1): 156/221 kB
Progress (1): 157/221 kB
Progress (1): 159/221 kB
Progress (1): 160/221 kB
Progress (1): 161/221 kB
Progress (1): 163/221 kB
Progress (1): 164/221 kB
Progress (1): 165/221 kB
Progress (1): 167/221 kB
Progress (1): 168/221 kB
Progress (1): 170/221 kB
Progress (1): 171/221 kB
Progress (1): 172/221 kB
Progress (1): 173/221 kB
Progress (1): 175/221 kB
Progress (1): 176/221 kB
Progress (1): 178/221 kB
Progress (1): 179/221 kB
Progress (1): 180/221 kB
Progress (1): 182/221 kB
Progress (1): 183/221 kB
Progress (1): 184/221 kB
Progress (1): 186/221 kB
Progress (1): 187/221 kB
Progress (1): 189/221 kB
Progress (1): 190/221 kB
Progress (1): 191/221 kB
Progress (1): 193/221 kB
Progress (1): 194/221 kB
Progress (1): 195/221 kB
Progress (1): 197/221 kB
Progress (1): 198/221 kB
Progress (1): 200/221 kB
Progress (1): 201/221 kB
Progress (1): 202/221 kB
Progress (1): 204/221 kB
Progress (1): 205/221 kB
Progress (1): 206/221 kB
Progress (1): 208/221 kB
Progress (1): 209/221 kB
Progress (1): 210/221 kB
Progress (1): 212/221 kB
Progress (1): 213/221 kB
Progress (1): 214/221 kB
Progress (1): 216/221 kB
Progress (1): 217/221 kB
Progress (1): 219/221 kB
Progress (1): 220/221 kB
Progress (1): 221 kB    
                    
Downloaded from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/org/apache/maven/plugins/maven-assembly-plugin/2.2.1/maven-assembly-plugin-2.2.1.jar (221 kB at 2.2 MB/s)
Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/com/fasterxml/jackson/core/jackson-annotations/2.8.1/jackson-annotations-2.8.1.pom
[WARNING] Failed to create parent directories for tracking file /home/jenkins/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.8.1/jackson-annotations-2.8.1.pom.lastUpdated
Downloading from central: https://repo.maven.apache.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.8.1/jackson-annotations-2.8.1.pom
[WARNING] Failed to create parent directories for tracking file /home/jenkins/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.8.1/jackson-annotations-2.8.1.pom.lastUpdated
Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/com/fasterxml/jackson/dataformat/jackson-dataformat-yaml/2.8.1/jackson-dataformat-yaml-2.8.1.pom
[WARNING] Failed to create parent directories for tracking file /home/jenkins/.m2/repository/com/fasterxml/jackson/dataformat/jackson-dataformat-yaml/2.8.1/jackson-dataformat-yaml-2.8.1.pom.lastUpdated
Downloading from central: https://repo.maven.apache.org/maven2/com/fasterxml/jackson/dataformat/jackson-dataformat-yaml/2.8.1/jackson-dataformat-yaml-2.8.1.pom
[WARNING] Failed to create parent directories for tracking file /home/jenkins/.m2/repository/com/fasterxml/jackson/dataformat/jackson-dataformat-yaml/2.8.1/jackson-dataformat-yaml-2.8.1.pom.lastUpdated
Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/com/fasterxml/jackson/core/jackson-databind/2.8.1/jackson-databind-2.8.1.pom
[WARNING] Failed to create parent directories for tracking file /home/jenkins/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.8.1/jackson-databind-2.8.1.pom.lastUpdated
Downloading from central: https://repo.maven.apache.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.8.1/jackson-databind-2.8.1.pom
[WARNING] Failed to create parent directories for tracking file /home/jenkins/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.8.1/jackson-databind-2.8.1.pom.lastUpdated
Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/org/codehaus/groovy/groovy-all/2.4.7/groovy-all-2.4.7.pom
Progress (1): 0.7/20 kB
Progress (1): 2.1/20 kB
Progress (1): 3.4/20 kB
Progress (1): 4.8/20 kB
Progress (1): 6.2/20 kB
Progress (1): 7.6/20 kB
Progress (1): 8.9/20 kB
Progress (1): 10/20 kB 
Progress (1): 12/20 kB
Progress (1): 13/20 kB
Progress (1): 13/20 kB
Progress (1): 15/20 kB
Progress (1): 16/20 kB
Progress (1): 17/20 kB
Progress (1): 19/20 kB
Progress (1): 20/20 kB
Progress (1): 20 kB   
                   
Downloaded from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/org/codehaus/groovy/groovy-all/2.4.7/groovy-all-2.4.7.pom (20 kB at 339 kB/s)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.429 s
[INFO] Finished at: 2019-01-17T16:21:50Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project repository-permissions-updater: Could not resolve dependencies for project io.jenkins.infra:repository-permissions-updater:jar:1.0-SNAPSHOT: Failed to collect dependencies at com.fasterxml.jackson.core:jackson-annotations:jar:2.8.1: Failed to read artifact descriptor for com.fasterxml.jackson.core:jackson-annotations:jar:2.8.1: Could not transfer artifact com.fasterxml.jackson.core:jackson-annotations:pom:2.8.1 from/to repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/): /home/jenkins/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.8.1/jackson-annotations-2.8.1.pom.part.lock (No such file or directory) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Archive)
[Pipeline] archiveArtifacts
Archiving artifacts
[Pipeline] archiveArtifacts
Archiving artifacts
‘json/*.json’ doesn’t match anything: even ‘json’ doesn’t exist
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Terminated

GitHub has been notified of this commit’s build result

ERROR: No artifacts found that match the file pattern "json/*.json". Configuration error?
Finished: FAILURE

Powered by the Comment Logger

@batmat batmat closed this Jan 17, 2019
@batmat batmat reopened this Jan 17, 2019
@pramodanarase
Copy link
Contributor Author

pramodanarase commented Jan 18, 2019

@daniel-beck - Can you make a second pass and merge it?

@batmat
Copy link
Contributor

batmat commented Jan 18, 2019

Merging to move forward. Thanks for your patience.

@batmat batmat merged commit 015f87e into jenkins-infra:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants