Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate dnsNames from jx-requirements ingress + environments config #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuasimon-taulia
Copy link

imo, this jx-requirements.yaml file should generate a cert that's compatible with staging.myorg.com and int.myorg.com

  environments:
  - key: dev
    owner: myorg-operations
    repository: jenkins-x-cluster
  - ingress:
      domain: staging.myorg.com
      externalDNS: true
      namespaceSubDomain: .
      tls:
        email: devops@myorg.com
        enabled: true
        production: true
    key: staging
    namespace: staging
  ingress:
    domain: int.myorg.com
    externalDNS: true
    kind: ingress
    namespaceSubDomain: -jx.
    tls:
      email: devops@myorg.com
      enabled: true
      production: true

i probably need tests if this is the accepted solution

@jenkins-x-bot-test
Copy link
Contributor

Hi @joshuasimon-taulia. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot-test
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ccojocar
You can assign the PR to them by writing /assign @ccojocar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants