Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

MavenSettingsSecurityXML added to templates and values file #4910

Merged
merged 2 commits into from Mar 13, 2019

Conversation

almerico
Copy link
Contributor

fixes #3413

@jenkins-x-bot
Copy link
Contributor

Hi @almerico. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@almerico
Copy link
Contributor Author

@ccojocar is it possible can you please take a look without this property we can't automate cluster upgrade in activiti

@salaboy
Copy link

salaboy commented Feb 27, 2019

This is really important for us and for everyone using settings-security.xml.. which I will assume that everyone will use in a way or another. @jstrachan @ccojocar thanks for your feedback.. if we can improve this in any way let us know

@jstrachan
Copy link
Member

/ok-to-test
/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstrachan
Copy link
Member

/test this

1 similar comment
@jstrachan
Copy link
Member

/test this

@jstrachan jstrachan merged commit 5d25a97 into jenkins-x:master Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specifying maven settings-security.xml at install not currently supported
5 participants