Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jx import] Makefile missing when using jx import #184

Closed
cyrille-leclerc opened this issue Feb 1, 2018 · 4 comments
Closed

[jx import] Makefile missing when using jx import #184

cyrille-leclerc opened this issue Feb 1, 2018 · 4 comments

Comments

@cyrille-leclerc
Copy link

cyrille-leclerc commented Feb 1, 2018

jx importdoes not create the Makefile charts/<MY_APP>/Makefile.

See cloudbeers/draft-spring-boot-app@90e95e2

See https://gist.github.com/cyrille-leclerc/f82afdd129b4516e6f84e0e7a4e5a860

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37.388 s
[INFO] Finished at: 2018-02-01T09:20:19+00:00
[INFO] Final Memory: 17M/25M
[INFO] ------------------------------------------------------------------------
[Pipeline] }
[Pipeline] // container
[Pipeline] dir
Running in /home/jenkins/workspace/raft-spring-boot-app_master-UYE7LYZTRFK2QPXLTMX2XRNZQF2OAOQU5YJA6IJXVYDFB3ZANCRQ/charts/draft-spring-boot-app
[Pipeline] {
[Pipeline] container
[Pipeline] {
[Pipeline] sh
[draft-spring-boot-app] Running shell script
+ make tag
make: *** No rule to make target `tag'.  Stop.
[Pipeline] }
[Pipeline] // container
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Deploy Staging)
Stage 'Deploy Staging' skipped due to earlier failure(s)
cyrille-leclerc pushed a commit to cloudbeers/draft-spring-boot-app that referenced this issue Feb 1, 2018
@rawlingsj
Copy link
Member

Can you double check the steps to recreate the problem please? I just tried to recreate:

  • I went to http://start.spring.io/
  • added web and actuator dependencies
  • downloaded zip
  • unzipped in my downloads folder
  • changed directory into the springboot project
  • ran jx import
  • pressed enter when asked "? Would you like to initialise git now? Yes"
  • pressed enter when asked "? Commit message: Initial import"
    and I can see that the makefile has been added.

I wonder if there's a different step or project type?

@jstrachan
Copy link
Member

what version of jx are you using? import is working in the BDD tests

rawlingsj added a commit that referenced this issue Feb 8, 2018
fix not being in the same namespace that we install jenkins x into fixes #184
@rawlingsj
Copy link
Member

oops referenced the wrong issue in the fix above, re-opening

@rawlingsj rawlingsj reopened this Feb 8, 2018
@cyrille-leclerc
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants