Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a jx create wizard/quickstart for lile #476

Closed
jstrachan opened this issue Mar 22, 2018 · 4 comments
Closed

add a jx create wizard/quickstart for lile #476

jstrachan opened this issue Mar 22, 2018 · 4 comments
Labels
area/quickstart for the Jenkins X quickstart apps good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jstrachan
Copy link
Member

this looks a nice fast way to create golang gRPC services
https://github.com/lileio/lile

might be nice to have a jx create lile or jx create quickstart lile wizard?

@jstrachan jstrachan added help wanted Extra attention is needed good first issue Good for newcomers area/quickstart for the Jenkins X quickstart apps labels Mar 22, 2018
@maniankara
Copy link

Hi @jstrachan! whats the idea behind this?
The challenge is, lile itself is a generator. I can see two options:

  1. Add a new entry with pre-generated values of lile to here
.
├── server
│   ├── server.go
│   └── server_test.go
├── subscribers
│   └── subscribers.go
├── app1
│   ├── cmd
│   │   ├── root.go
│   │   └── up.go
│   └── main.go
├── app1.proto
├── client.go
├── Makefile
├── Dockerfile
└── .gitignore

Then any updates to lile generator mainstream does not come automatically.
2. Make a way to run lile with jx.
In that case, more information is needed on how to implemented.

@jstrachan
Copy link
Member Author

I was thinking of option 2 - run lile from the command line to generate a new project source then effectively run jx import on the generated source. That is kinda what jx create spring & jx create quickstart do today; a wizard to generate a project source - then is imported (creating a git repo, adding the build pack etc).

Maybe the code of those 2 commands might act as a base for creating create_lile.go?

@jstrachan
Copy link
Member Author

eg https://github.com/jenkins-x/jx/blob/master/pkg/jx/cmd/create_spring.go

a first cut could be to run lile to create the project then call the import function like the last line in the above go file

maniankara added a commit to maniankara/jx that referenced this issue Apr 10, 2018
Now its possible to create and import lile generated gRPC services

Fixes jenkins-x#476
maniankara added a commit to maniankara/jx that referenced this issue Apr 10, 2018
Now its possible to create and import lile generated gRPC services

Fixes jenkins-x#476
@maniankara
Copy link

@jstrachan I didnt manage to write any unit test for these. Let me know if needed.

maniankara added a commit to maniankara/jx that referenced this issue Apr 11, 2018
cmdOut, which contains the output of lile is not necessary (very verbose)

Fixes: jenkins-x#476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quickstart for the Jenkins X quickstart apps good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants