JX boot - running boot twice on a vault cluster overwrites secrets

[warrenbailey]

Summary

Switching from local storage to vault storage in a jx boot cluster results in an error and an incorrect value being stored in vault.

Steps to reproduce the behavior

1. Create a new jx boot cluster with local storage enabled
2. Update jx-requirements.yaml and change to vault storage
3. Re-run 'jx boot'

Expected behavior

Secret storage is switched from local storage to vault storage

Actual behavior

'jx boot' fails and an incorrect value ends up in vault

Creating repository warrenbailey-org/environment-wbailey-boot-3-production
Creating Git repository warrenbailey-org/environment-wbailey-boot-3-production
error: failed to create git repository for gitURL https://github.com/warrenbailey-org/environment-wbailey-boot-3-production.git: creating the repository: Failed to create repository warrenbailey-org/environment-wbailey-boot-3-production due to: POST https://api.github.com/orgs/warrenbailey-org/repos: 401 Bad credentials []
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c jx step verify env' command in directory '.', output: ''

vault kv get secret/wbailey-boot-3/pipelineUser
====== Metadata ======
Key              Value
---              -----
created_time     2019-08-16T09:37:29.19057689Z
deletion_time    n/a
destroyed        false
version          1

==== Data ====
Key      Value
---      -----
token    local:wbailey-boot-3/pipelineUser:token

Jx version

The output of jx version is:

COPY OUTPUT HERE

Jenkins type

• Serverless Jenkins X Pipelines (Tekton + Prow)
• Classic Jenkins

Kubernetes cluster

Operating system / Environment

[warrenbailey]

Actually we've just seen this happening on a vault cluster when running jx boot for a second time.

Though the value in vault is of the format

token vault:wbailey-boot-3/pipelineUser:token