Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jx boot pipleine run in a pipeline without tls enabled will fail #5237

Closed
pmuir opened this issue Aug 28, 2019 · 0 comments · Fixed by #5241
Closed

jx boot pipleine run in a pipeline without tls enabled will fail #5237

pmuir opened this issue Aug 28, 2019 · 0 comments · Fixed by #5241
Assignees
@pmuir
Labels
area/boot issues in the `jx boot` command kind/bug Issue is a bug priority/critical
Milestone
Sprint 13

Comments

@pmuir
Copy link
Contributor

pmuir commented Aug 28, 2019

Summary

We added a verification to jx step verify preinstall which fails installs if TLS is not enabled. This fails in a pipeline and currently there is no override. After talking again with @ccojocar we have agreed that the confirmation is ok to be ignored in batch mode. We will also add a link to docs.
@pmuir pmuir self-assigned this Aug 28, 2019
@pmuir pmuir added this to the Sprint 13 milestone Aug 28, 2019
@pmuir pmuir added area/boot issues in the `jx boot` command kind/bug Issue is a bug priority/critical labels Aug 28, 2019
pmuir added a commit to pmuir/jx that referenced this issue Aug 28, 2019
@pmuir
fix: allow install without TLS in batch mode
4873685 
fixes jenkins-x#5237
Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
@pmuir pmuir mentioned this issue Aug 28, 2019
Merged
2 tasks
pmuir added a commit to pmuir/jx that referenced this issue Aug 28, 2019
@pmuir
fix: allow install without TLS in batch mode
b6e61ce 
fixes jenkins-x#5237
Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir added a commit to pmuir/jx that referenced this issue Aug 28, 2019
@pmuir
fix: allow install without TLS in batch mode
f48919f 
fixes jenkins-x#5237
Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir added a commit to pmuir/jx that referenced this issue Aug 28, 2019
@pmuir
fix: allow install without TLS in batch mode
ceef599 
fixes jenkins-x#5237
Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
jenkins-x-bot pushed a commit that referenced this issue Aug 28, 2019
@pmuir @jenkins-x-bot
fix: allow install without TLS in batch mode
98f1888 
fixes #5237
Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
@pmuir
fix: allow install without TLS in batch mode
db9527b 
fixes jenkins-x#5237
Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmuir pmuir

Labels
area/boot issues in the `jx boot` command kind/bug Issue is a bug priority/critical
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging a pull request may close this issue.

fix: allow install without TLS in batch mode pmuir/jx
2 participants
@pmuir @deanesmith