-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jx upgrade ingress lost all ingress rules #5800
Comments
here's the record, start at 20s. |
Hello @zhaochunqi , Having same issue using "jx upgrade ingress" deletes standard ingress rules and don't recreates the new one. No error shown in console just as your record posted above. When running "jx get applications". shows the version and pods but no URL. This was working fine last week. We created 5 new ingress rules with "jx upgrade ingress". But today is not working. We are using AWS with Classic Jenkins. Can any one help? Thanks |
I found a work around to expose ingress rules by hand, From the logs of In LINUX After forcing the following command, the ingress configuration start working:
Could be that I see that Jenkins x rocks, thank you for all your hard work! |
@matiashaller I followed your workaround, seems not working. (edited, should change urlTemplate) This was working fine weeks ago for me too. |
Hey @matiashaller - so @zhaochunqi and I have found that the issue for us lies in this update jenkins-x/exposecontroller#191 where the configmap will add an extra layer of quotes around the URL template config, and the template generation command that is being run in We basically had to remove the quotes in the generated template and manually run them to make it to work. So it seems like we will have to fix it in the |
Same problem here. It worked fine a few weeks ago to upgrade our ingress to use TLS, now when we try it, it completely removes the ingress instead of just enabling TLS :'( Can we manually recreate the ingress or do we have to delete our entire environment and start over to at least get a non-TLS ingress? |
OOI, in which context are you running |
Cool. Looking at the PR. Unfortunately, it seems though that the change breaks the ingress upgrade BDD test - https://github.com/jenkins-x/bdd-jx/blob/master/test/suite/ingress/jx_upgrade_ingress.go |
@hferentschik we can look into the test and fix the test, as long as it is the right change. Since we have found it is currently inconsistent with the |
@hferentschik Is there a way I can see the error that is in the BDD test? This way I might be able to help identify the issue. |
@Markus-ipse Hey we only had to trigger the deployment one more time (by making an empty/meaningless commit on the Once the ingress is back up, try to run |
@lhr0909 I'm unable to find the raw template unfortunately. Using verbose didn't output anything indicating where the template files are stored, and I've tried searching /var/folders/ recursivly for any files named part0* and it returned nothing :'( |
Try to run
|
I did run the command with the verbose flag, but I also included domain, services and force:
I've gone over the output line-by-line multiple times and the only lines from the entire output that contain any sort of path (excluding urls) where the following two lines
This is quite the showstopper for us so I really hope the PR gets merged :) |
It is possible that the BDD tests for this are failing due to the expose controller version and needs further investigation |
Signed-off-by: Simon Liang <no.lhr0909@gmail.com> fixes jenkins-x#5800
- only include non empty values in helm argument list fixes jenkins-x#5800 Signed-off-by: Simon Liang <no.lhr0909@gmail.com>
- only include non empty values in helm argument list fixes jenkins-x#5800
- only include non empty values in helm argument list fixes #5800
- only include non empty values in helm argument list fixes jenkins-x#5800
Summary
jx upgrade ingress
lost all ingress rulesSteps to reproduce the behavior
jx upgrade ingress
and set custom template to"{{.Service}}.{{.Domain}}"
Expected behavior
update success
Actual behavior
the console shows ingress rules created. but that's not true, I cannot find any ingress rules after that.
Jx version
The output of
jx version
is:Jenkins type
I'm using multi-cluster, this happens on the production cluster.
Kubernetes cluster
Operating system / Environment
The text was updated successfully, but these errors were encountered: