Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitBucket Server with boot/gitops/vault gets error for "No git service found" #6589

Closed
abayer opened this issue Jan 22, 2020 · 0 comments · Fixed by #6590
Closed

BitBucket Server with boot/gitops/vault gets error for "No git service found" #6589

abayer opened this issue Jan 22, 2020 · 0 comments · Fixed by #6590
Assignees
Labels
area/auth area/git-providers kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@abayer
Copy link
Contributor

abayer commented Jan 22, 2020

create spring
 Given valid parameters when running ** create spring 
  creates a spring application and promotes it to staging
  
  /tmp/jenkins-x/bdd-**/test/suite/spring/**_create_spring.go:36
      Using Git provider URL https://bitbucket.beescloud.com
STEP: calling ** create spring -b --org **bdd --artifact bdd-spring-1579611559 --name bdd-spring-1579611559 -d web -d actuator --git-provider-url https://bitbucket.beescloud.com
      RUNNER:About to execute ** create spring -b --org **bdd --artifact bdd-spring-1579611559 --name bdd-spring-1579611559 -d web -d actuator --git-provider-url https://bitbucket.beescloud.com in /tmp/bdd-953564943 with timeout 1h0m0s expecting exit code 0
Command "spring" is deprecated, it will be removed on Feb 1 2020. We now highly recommend you use ** create quickstart instead. Please check https://jenkins-x.io/docs/getting-started/first-project/create-quickstart/ for more details.
Created Spring Boot project at /tmp/bdd-953564943/bdd-spring-1579611559
error: no Git service resource found with URL 'https://bitbucket.beescloud.com' in namespace **
      RUNNER:Execution completed with exit code 1
      FAILED got unexpected error: 
expected exit code 0 but got 1 whilst running command ** create spring -b --org **bdd --artifact bdd-spring-1579611559 --name bdd-spring-1579611559 -d web -d actuator --git-provider-url https://bitbucket.beescloud.com

This is another side effect of the move away from secrets to the jx-auth-config configmap. When there's no explicit kind for the server during jx import and friends, we first check to see if the URL matches a known pattern for providers supported by the SaaS, then we check for jx-pipeline-git- secrets, and lastly we check the at-this-point-defunct list of GitServices. GitHub, BitBucket Cloud, and gitlab.com all get their kind detected by the SaaS provider check, as does GitHub Enterprise if the service URL starts with https://github. Anything else (i.e., any self-hosted Gitlab or BitBucket Server, and any self-hosted GHE that isn't on https://github(something)) just won't get detected.

@abayer abayer added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Issue is a bug area/git-providers area/auth in progress estimate/S labels Jan 22, 2020
@abayer abayer added this to the Sprint 1 2020 milestone Jan 22, 2020
@abayer abayer self-assigned this Jan 22, 2020
abayer added a commit to abayer/jx that referenced this issue Jan 22, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes jenkins-x#6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer added a commit to abayer/jx that referenced this issue Jan 22, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes jenkins-x#6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer added a commit to abayer/jx that referenced this issue Jan 23, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes jenkins-x#6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer added a commit to abayer/jx that referenced this issue Jan 23, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes jenkins-x#6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer added a commit to abayer/jx that referenced this issue Jan 23, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes jenkins-x#6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
jenkins-x-bot pushed a commit that referenced this issue Jan 23, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes #6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
We're looking for this in a simple set of patterns, secrets, and
`GitServices`, but once the `jx-auth-config` configmap is present
(i.e., via a combination of boot/vault/gitops), we won't be able to
find the kind for something that doesn't match one of the patterns we
check first, since the `jx-pipeline-git-` secrets won't exist any
more. So if we're in a cluster with `jx-auth-config`, let's look up
there too, before we check secrets or `GitServices`.

fixes jenkins-x#6589

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth area/git-providers kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants