fix: refactor cmd package by moving utility functions out #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccojocar
force-pushed
the
refactor_cmd_package
branch
2 times, most recently
from
9f19a58
to
f89d9db
Compare
|
@ccojocar sorry about that, think my PR to minimise the BDD footprint caused a conflict - hopefully its easy to resolve |
ccojocar
force-pushed
the
refactor_cmd_package
branch
from
f89d9db
to
7347b4f
Compare
|
@jstrachan it should be fixed now. |
|
@ccojocar sorry one more rebase ;). As soon as it’s green do you wanna hit merge? The BDD testing per PR seems to be working & is of a smallish footprint now |
ccojocar
force-pushed
the
refactor_cmd_package
branch
from
7347b4f
to
47d39fb
Compare
|
@jstrachan is green again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first round of refactoring for #1016