New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(#2496) add support for bash completion on debian devpod images #2497

Merged
merged 4 commits into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@aweis89
Copy link
Contributor

aweis89 commented Dec 12, 2018

Description

  1. Prevent jx create devpod from exiting with 127 when yum or apt-get is not available to install bash completion packages.
  2. If yum is not available, attempt to use apt-get to support debian based images

Which issue this PR fixes

fixes #2496

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 12, 2018

Hi @aweis89. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 13, 2018

/ok-to-test

@jenkins-x-bot jenkins-x-bot merged commit cb6412e into jenkins-x:master Dec 13, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment