New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only load managed plugins if CRD available #2531

Merged
merged 4 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@pmuir
Copy link
Member

pmuir commented Dec 18, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from amuniz and jtnord Dec 18, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 18, 2018

/uncc @jtnord
/uncc @amuniz
/cc @garethjevans

@jenkins-x-bot jenkins-x-bot requested review from garethjevans and removed request for jtnord and amuniz Dec 18, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/lgtm

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

Fixes #2526

@pmuir pmuir force-pushed the pmuir:no-lazy-crd branch from e9cb651 to dcfd2b5 Dec 18, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 18, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/test bdd

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added lgtm and removed lgtm labels Dec 18, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 18, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 18, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 18, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 18, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ccojocar,garethjevans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit c9237be into jenkins-x:master Dec 18, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment