Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing step values schema template #3814

Merged
merged 1 commit into from Apr 30, 2019

Conversation

pmuir
Copy link
Contributor

@pmuir pmuir commented Apr 30, 2019

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
@jstrachan
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmuir
Copy link
Contributor Author

pmuir commented Apr 30, 2019

/test all

@pmuir
Copy link
Contributor Author

pmuir commented Apr 30, 2019

/override tekton

@jenkins-x-bot
Copy link
Contributor

@pmuir: Overrode contexts on behalf of pmuir: tekton

In response to this:

/override tekton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jenkins-x-bot jenkins-x-bot merged commit 739f6a2 into jenkins-x:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants