Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip dir when loop Helm templates #7441

Merged
merged 1 commit into from Jul 23, 2020

Conversation

nodece
Copy link

@nodece nodece commented Jul 15, 2020

Signed-off-by: Zixuan Liu nodeces@gmail.com

Which issue this PR fixes

fixes #7359

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@jenkins-x-bot
Copy link
Contributor

Hi @nodece. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@rawlingsj
Copy link
Member

/ok-to-test

@MarckK
Copy link
Member

MarckK commented Jul 23, 2020

/lgtm

@MarckK
Copy link
Member

MarckK commented Jul 23, 2020

Thank you @nodece!

@rawlingsj
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarckK, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 29c812c into jenkins-x:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jx add app fails for helm charts containing sub-folders in the templates folder
4 participants