Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dockerfile agent declaration with filename #598

Conversation

zgyorffi
Copy link

I came across a limitation, the library does not support a jenkinsfile I am using even though it is completely valid and works fine on Jenkins. I've created this pull request to address this limitation so that I could continue the journey with this library. I am basically a newbie to groovy (just implemented a few jenkinsfiles in it so far) so open to any suggestions. I followed the pattern used for KubernetesAgentDeclaration and moved DockerfileAgentDeclaration in a dedicated class.

An example jenkinsfile which should be supported:

pipeline {
    stages {
        stage('Build') {
            agent {
                dockerfile {
                    filename 'Dockerfile'
                }
            }
        }
    }
}
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@nre-ableton nre-ableton merged commit 9ab5768 into jenkinsci:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants