Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jenkinsci-1053] Add test DisplayUrlApi #1079

Closed
wants to merge 2 commits into from
Closed

[jenkinsci-1053] Add test DisplayUrlApi #1079

wants to merge 2 commits into from

Conversation

ampuscas
Copy link
Contributor

related to #1053

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

NotMyFault
NotMyFault reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left some feedback for consideration :)

src/main/java/org/jenkinsci/test/acceptance/PipelineTestUtils.java Show resolved Hide resolved
src/main/java/org/jenkinsci/test/acceptance/PipelineTestUtils.java Show resolved Hide resolved
src/main/java/org/jenkinsci/test/acceptance/PipelineTestUtils.java Show resolved Hide resolved
src/main/java/org/jenkinsci/test/acceptance/PipelineTestUtils.java Show resolved Hide resolved
src/main/java/org/jenkinsci/test/acceptance/PipelineTestUtils.java Show resolved Hide resolved
src/test/java/plugins/DisplayUrlApiTest.java Show resolved Hide resolved
@ampuscas
Copy link
Contributor Author

I am closing this PR, I have added this test on another PR -> #1083

@ampuscas ampuscas closed this Mar 28, 2023
@NotMyFault
Copy link
Member

I am closing this PR, I have added this test on another PR -> #1083

Would you mind addressing my feedback on the other PR?

@ampuscas
Copy link
Contributor Author

Would you mind addressing my feedback on the other PR?

Yes, of course, I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault left review comments

@julieheard julieheard julieheard approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ampuscas @NotMyFault @julieheard