Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven in tests #1327

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Update maven in tests #1327

merged 1 commit into from
Aug 13, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Aug 13, 2023

Update maven to 3.9.4 in test cases, matching the maven version used in the dockerfile

@NotMyFault NotMyFault changed the title Replace repository in 'WorkflowMultibranchTest' with general repo Update maven in tests Aug 13, 2023
@NotMyFault NotMyFault added the dependencies Pull requests that update a dependency file label Aug 13, 2023
@NotMyFault NotMyFault marked this pull request as ready for review August 13, 2023 09:30
@timja timja merged commit a10d5f9 into jenkinsci:master Aug 13, 2023
27 checks passed
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes regressions or flaky tests depending on your environment.

As the version is not in the installed metadata - it relies on a successful update having being retrieved from the update center at the time it was done.

jtnord added a commit that referenced this pull request Sep 8, 2023
ammends #1327 to provide the required metadata
jtnord added a commit that referenced this pull request Sep 8, 2023
* Update missing tool installation for maven 3.9.4

amends #1327 to provide the required metadata

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants