Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing tool installation for maven 3.9.4 #1357

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Sep 8, 2023

amends #1327 to provide the required metadata

Without the metadata all the changed tests became flaky or failed reliably (depending on infrastructure setup) due to requiring a successful update from the update center.

Testing done

none

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

ammends #1327 to provide the required metadata
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know! I wasn't aware of the regression, tests were successful in my initial PR

@jtnord jtnord enabled auto-merge (squash) September 8, 2023 10:21
@jtnord jtnord merged commit ae19d1e into master Sep 8, 2023
24 of 27 checks passed
@jtnord jtnord deleted the jtnord-patch-1 branch September 8, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants