Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward compatibility for use Jenkins modal for 'Apply' button failures #1446

Merged
merged 5 commits into from Dec 17, 2023
Merged

Forward compatibility for use Jenkins modal for 'Apply' button failures #1446

merged 5 commits into from Dec 17, 2023

Conversation

timja
Copy link
Member

@timja timja commented Dec 17, 2023

see jenkinsci/jenkins#8394

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

timja
timja commented Dec 17, 2023
View reviewed changes
src/test/java/plugins/ScriptSecurityPluginTest.java
@@ -116,6 +116,7 @@ public void scriptNeedsApproval() throws Exception {

@Test
@WithPlugins("groovy-postbuild")
@Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1444

@timja timja marked this pull request as ready for review December 17, 2023 13:26
@timja timja changed the title Test - Use Jenkins modal for 'Apply' button failures Forward compatibility for use Jenkins modal for 'Apply' button failures Dec 17, 2023
@timja timja enabled auto-merge (squash) December 17, 2023 13:27
@timja timja mentioned this pull request Dec 17, 2023
Merged
@timja timja merged commit 81b784f into master Dec 17, 2023
27 checks passed
@timja timja deleted the timja-patch-1 branch December 17, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timja