[JENKINS-57804] Fix typo in the name of the checkbox that enables user signup for the HudsonSecurityRealm page object #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signup for the HudsonSecurityRealm page object
jtnord
approved these changes
Jun 3, 2019
|
Spot on. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-57804
The page object that can be used to configure the JenkinsDatabaseSecurityRealm in acceptance tests has a typo in the element name used to enable/disable the ability for users to self-register (ie. signup) when using this realm. The jelly form control is named "allowsSignup" but the pageobject references it using the name "allowSignup". This causes any ATH tests that rely on manipulating that element to fail with an element not found/Timeout exception.
This was brought to light as the result of a recent change that forces the UI behavior to disable user signup by default (as a security precaution), which in turn caused some tests, which expected this to be enabled by default, to break.
This PR addresses that by fixing the name of the control used by the page object. I've no idea if which spelling was intended to be correct, but this was the on that was inconsistent with the rest.