Adapt to core and plugin changes

[timja]

Adapt to:

• Add "copy to clipboard" button to the script console output jenkins#6455
• Use f:dropdownDescriptorSelector for agent launcher jenkins#6464

TODO:

• Regression in Fix button size of "+ Add" credentials-plugin#296 needs fixing, see Forward compatibility for tippy #759 (comment)

FYI @NotMyFault @janfaracik

Let's get these builds green again before testing anything

[jtnord]

this is likely going to be an issue as there are multiple ways to "launch agents via SSH" (one is cloudbees specific with non blocking, and the other is the OSS ssh-slaves plugin. we should always be able to use the class name of the describable to not be dependant on any naming changes. has the UI changed such that the describable is no longer picked up correctly (should be ok as without it databinding will likely not work)

[timja]

It's changed to use jenkinsci/jenkins#6464

Which is keyed by the loop index, https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly#L61

[jtnord]

the majority of remaining failures seem to be the inability to select credentials for the SSH agents

Unable to locate By.xpath: //*[@id='credentials-dialog-form']//*[@path='/'] in http://127.0.0.1:62883/computer/createItem
Stacktrace
org.openqa.selenium.NoSuchElementException: Unable to locate By.xpath: //*[@id='credentials-dialog-form']//*[@path='/'] in http://127.0.0.1:62883/computer/createItem
	at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl.find(CapybaraPortingLayerImpl.java:199)
	at org.jenkinsci.test.acceptance.po.Control.resolve(Control.java:75)
	at org.jenkinsci.test.acceptance.po.Control.select(Control.java:286)
	at org.jenkinsci.test.acceptance.plugins.ssh_credentials.SshCredentialDialog$1.resolve(SshCredentialDialog.java:36)
	at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl$Resolver.find(CapybaraPortingLayerImpl.java:532)
	at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl.findCaption(CapybaraPortingLayerImpl.java:483)
	at org.jenkinsci.test.acceptance.plugins.ssh_credentials.SshCredentialDialog.select(SshCredentialDialog.java:33)

[timja]

Credentials plugin issue caused by jenkinsci/jenkins#6464

[timja]

The other test failing is:
plugins.NodeLabelParameterPluginTest#run_on_several_online_and_offline_slaves

Bisect shows:

900374e12421204f9ad76ac84397e96b9399cf00 is the first bad commit
commit 900374e12421204f9ad76ac84397e96b9399cf00
Author: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
Date:   Fri Apr 15 21:59:48 2022 +0100

    [JENKINS-68129] Fix dropdown chevrons not separating links and overflowing (#6481)

 war/src/main/less/modules/breadcrumbs.less | 175 ++++++++++++++++-------------
 war/src/main/less/modules/page-header.less |  13 ++-
 war/src/main/less/modules/table.less       |   6 +
 3 files changed, 113 insertions(+), 81 deletions(-)

cc @janfaracik

haven't confirmed yet if regression or test needs changing - While it doesn't look ideal I don't think it's a regression, there's just a newline in the DOM now

2.343:

2.344:

[NotMyFault]

The checks are passing here but failing again on master, huh?

[timja]

The checks are passing here but failing again on master, huh?

yes because jenkinsci/jenkins#6519 is not released yet.

I used the incremental from master branch to test this in the meantime