Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68338] Credentials popup does not work in SSH Build Agents (regression in 2.344) #6519

Merged
merged 1 commit into from Apr 29, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 27, 2022

In the absence of a verified fix for JENKINS-68338 by the end of the week, I plan to revert #6464 toward 2.346.

Proposed changelog entries

Restore functionality of credentials popup in SSH Build Agents (regression in 2.344).

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases squash-merge-me Unclean or useless commit history, should be merged only with squash-merge labels Apr 27, 2022
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I agree that we need to revert this before the next weekly.

@basil
Copy link
Member Author

basil commented Apr 29, 2022

Expediting this toward 2.346.

@basil basil merged commit 23a8ef5 into jenkinsci:master Apr 29, 2022
@basil basil deleted the JENKINS-68338 branch April 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-fix Pull request that fixes a regression in one of the previous Jenkins releases squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
2 participants