forked from biouno/uno-choice-plugin
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-62317]: Upgrade dependencies pre 2.3 release #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build passing locally now. Pending:
|
Smoke tests look good. |
kinow
changed the title
Upgrade dependencies pre 2.3 release
[JENKINS-62317]: Upgrade dependencies pre 2.3 release
May 16, 2020
…rness provided methods
…now the dependencyManagement)
…kins.getInstanceOrNull()
kinow
force-pushed
the
upgrade-dependencies
branch
from
May 16, 2020 06:55
2fde596
to
051af2b
Compare
Issue created, commits re-worded. https://issues.jenkins-ci.org/browse/JENKINS-62317 |
Tested the following:
Everything worked fine.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using git-plugin as reference. One major issue is that the build is failing due to hamcrest dependency, coming from powermock.
I think we will need to update to JUnit5, and replace Powermock with... mockito maybe.