Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-62317]: Upgrade dependencies pre 2.3 release #34

Merged
merged 9 commits into from May 16, 2020

Conversation

kinow
Copy link
Member

@kinow kinow commented May 15, 2020

Using git-plugin as reference. One major issue is that the build is failing due to hamcrest dependency, coming from powermock.

I think we will need to update to JUnit5, and replace Powermock with... mockito maybe.

@kinow kinow self-assigned this May 15, 2020
@kinow
Copy link
Member Author

kinow commented May 15, 2020

Build passing locally now. Pending:

  • smoke test with some builds
  • check if there's any obvious issue for users upgrading their installations
  • create ticket or add to release notes (or both)

@kinow kinow marked this pull request as ready for review May 15, 2020 12:18
@kinow
Copy link
Member Author

kinow commented May 16, 2020

Smoke tests look good.

@kinow kinow changed the title Upgrade dependencies pre 2.3 release [JENKINS-62317]: Upgrade dependencies pre 2.3 release May 16, 2020
@kinow
Copy link
Member Author

kinow commented May 16, 2020

Issue created, commits re-worded. https://issues.jenkins-ci.org/browse/JENKINS-62317

@kinow
Copy link
Member Author

kinow commented May 16, 2020

check if there's any obvious issue for users upgrading their installations

Tested the following:

  • Installed latest LTS 2.222.3
  • Installed recommended plugins
  • Tested one job with active choices parameter, and another reactive parameter (state & city example from wiki)
  • Installed Scriptler
  • Moved City parameter script to groovy

Everything worked fine.

  • Installed the package created from this branch with mvn package. It appeared on the list of plug-ins as 2.3-SNAPSHOT
  • Loaded existing job with no warnings/exceptions
  • Executed job again, no issues
  • Loaded previous builds and accessed parameter info
  • Modified job to have a third dynamic reference parameter
  • Looks good to me, 🏁 ✔️

@kinow kinow merged commit 4e19144 into jenkinsci:master May 16, 2020
@kinow kinow deleted the upgrade-dependencies branch May 16, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant