Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let "PhantomJS Unit Testing" be able to run on both linux and windows… #6

Merged
merged 2 commits into from
Nov 1, 2015

Conversation

lyenliang
Copy link
Member

… platform.

@lyenliang
Copy link
Member Author

Hi, I just found that I couldn't build Active Choices Plugin on windows platform. The reason is runner.sh is not a valid win32 app (CreateProcess error=193). So I created a runner.bat for windows and determine the platform in pom.xml.

kinow added a commit that referenced this pull request Nov 1, 2015
Let "PhantomJS Unit Testing" be able to run on both linux and windows…
@kinow kinow merged commit 6a307df into jenkinsci:master Nov 1, 2015
@kinow
Copy link
Member

kinow commented Nov 1, 2015

Merged. Thanks @lyenliang !

@lyenliang
Copy link
Member Author

You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants