Add archiver (fixes #87) #89
Conversation
| ZipEntry dirZipEntry = new ZipEntry(relativePath+'/'); | ||
| // Setting this bit explicitly is needed by some unzipping applications (see JENKINS-3294). | ||
| dirZipEntry.setExternalAttributes(BITMASK_IS_DIRECTORY); | ||
| //if (mode!=-1) dirZipEntry.setUnixMode(mode); // TODO |
There was a problem hiding this comment.
Complete the task associated to this TODO comment. 
This block of commented-out lines of code should be removed.
| } | ||
|
|
||
| @Override | ||
| public void visit(final File f, final String _relativePath) throws IOException { |
There was a problem hiding this comment.
Rename this local variable name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
| public Archiver create(OutputStream out) throws IOException { | ||
| return new TrueZipArchiver(out); | ||
| } | ||
| }; |
|
|
||
| @Override | ||
| public void visit(final File f, final String _relativePath) throws IOException { | ||
| // int mode = IOUtils.mode(f); // TODO |
There was a problem hiding this comment.
Complete the task associated to this TODO comment.
| zip.closeEntry(); | ||
| } else { | ||
| ZipEntry fileZipEntry = new ZipEntry(relativePath); | ||
| //if (mode!=-1) fileZipEntry.setUnixMode(mode); // TODO |
There was a problem hiding this comment.
This block of commented-out lines of code should be removed.
Complete the task associated to this TODO comment.
| entriesWritten++; | ||
| } | ||
|
|
||
| public void close() throws IOException { |
There was a problem hiding this comment.
Add the "@OverRide" annotation above this method signature
| } | ||
|
|
||
| // Bitmask indicating directories in 'external attributes' of a ZIP archive entry. | ||
| private static final long BITMASK_IS_DIRECTORY = 1<<4; |
There was a problem hiding this comment.
Move this variable to comply with Java Code Conventions.
| // Bitmask indicating directories in 'external attributes' of a ZIP archive entry. | ||
| private static final long BITMASK_IS_DIRECTORY = 1<<4; | ||
|
|
||
| public static final ArchiverFactory FACTORY = new Factory(); |
There was a problem hiding this comment.
Move this variable to comply with Java Code Conventions.
|
SonarQube analysis reported 11 issues:
Watch the comments in this conversation to review them. |
No description provided.